Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update GetPasswordResetEmail to use EmailService V2 #119

Merged
merged 4 commits into from
Oct 13, 2020
Merged

feat: Update GetPasswordResetEmail to use EmailService V2 #119

merged 4 commits into from
Oct 13, 2020

Conversation

kzalys
Copy link
Collaborator

@kzalys kzalys commented Oct 12, 2020

For issue #118

Updates the GetPasswordResetEmail to use EmailServiceV2 to send out the password reset email.

@kzalys kzalys added the auth-v2 Issues relating to the Auth V2 design label Oct 12, 2020
@kzalys kzalys self-assigned this Oct 12, 2020
@codecov
Copy link

codecov bot commented Oct 12, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@caf5b19). Click here to learn what that means.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #119   +/-   ##
=========================================
  Coverage          ?   89.95%           
=========================================
  Files             ?       33           
  Lines             ?     2309           
  Branches          ?        0           
=========================================
  Hits              ?     2077           
  Misses            ?      167           
  Partials          ?       65
Impacted Files Coverage Δ
routers/api/v2/users.go 93.63% <57.89%> (ø)
services/sendgrid/v2/emailService.go 91.04% <90.00%> (ø)
authorization/v2/authorizer.go 98.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caf5b19...99ae1d1. Read the comment docs.

seanjparker
seanjparker suggested changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@seanjparker seanjparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of questions

services/sendgrid/v2/emailService.go Outdated Show resolved Hide resolved
services/sendgrid/v2/emailService.go Show resolved Hide resolved
@kzalys kzalys linked an issue Oct 13, 2020 that may be closed by this pull request
API V2 - GetPasswordResetEmail does not use EmailService v2 #118
Closed
seanjparker
seanjparker approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@seanjparker seanjparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kzalys kzalys merged commit 997e718 into master Oct 13, 2020
@kzalys kzalys deleted the feat/password-reset-email-v2 branch October 13, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanjparker seanjparker seanjparker approved these changes

Assignees

@kzalys kzalys

Labels
auth-v2 Issues relating to the Auth V2 design
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API V2 - GetPasswordResetEmail does not use EmailService v2
2 participants
@kzalys @seanjparker