Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate frontend team management to auth v2 #133

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

kzalys
Copy link
Collaborator

@kzalys kzalys commented Oct 17, 2020

For issue #106

Migrates frontend team management to auth v2.

@kzalys kzalys added the auth-v2 Issues relating to the Auth V2 design label Oct 17, 2020
@kzalys kzalys self-assigned this Oct 17, 2020
@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #133 into master will increase coverage by 1.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
+ Coverage   91.24%   92.46%   +1.22%     
==========================================
  Files          36       36              
  Lines        2318     2323       +5     
==========================================
+ Hits         2115     2148      +33     
+ Misses        142      117      -25     
+ Partials       61       58       -3     
Impacted Files Coverage Δ
...thorization/v2/common/uniformResourceIdentifier.go 95.38% <100.00%> (ø)
routers/frontend/router.go 100.00% <100.00%> (+4.34%) ⬆️
routers/frontend/routes.go 95.73% <100.00%> (+8.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7588743...adbc48d. Read the comment docs.

Copy link
Contributor

@seanjparker seanjparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@kzalys kzalys force-pushed the feat/migrate-frontend-team-management-to-auth-v2 branch from 7329a8f to d8e7b40 Compare October 19, 2020 21:32
@kzalys kzalys force-pushed the feat/migrate-frontend-team-management-to-auth-v2 branch from d8e7b40 to adbc48d Compare October 19, 2020 21:33
@kzalys kzalys merged commit 192fc3e into master Oct 19, 2020
@kzalys kzalys deleted the feat/migrate-frontend-team-management-to-auth-v2 branch October 19, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth-v2 Issues relating to the Auth V2 design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants