Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#180 - Generic React components #220

Merged
merged 19 commits into from
Feb 1, 2020
Merged

#180 - Generic React components #220

merged 19 commits into from
Feb 1, 2020

Conversation

adamkendis
Copy link
Member

Closes #180
@brodly

NOTE: Dropdown component is not included in this PR. Slightly more involved than the other components and will be split into its own ticket.

Generic React components adhering to Bulma style modifiers:

  • Button
  • Checkbox/Radio
  • ToggleSwitch

Components receive props corresponding with Bulma modifiers, which are passed to classNames for conditional class name generation.

Bulma-checkradio and Bulma-switch used to extend Bulma functionality.

adamkendis and others added 15 commits January 28, 2020 12:09
@adamkendis
Added classnames dependency. Used for dynamic className generation to…
81dc730 
… comply with Bulma style modifiers.
@adamkendis
Generic button component adhering to Bulma styling modifiers.
89ea9ca
@adamkendis
Rephrased comment for greater clarity.
b0c5060
@adamkendis
Added bulma-checkradio and react-id-generator dependencies.
99de5cb
@adamkendis
Unique id generation added to Button component.
171e794
@adamkendis
Bulma-checkradio import.
79ffb1c
@adamkendis
Generic checkbox component adhering to Bulma-checkradio extension sty…
08fd652 
…ling modifiers.
@adamkendis
Added type attribute to Checkbox props.
7e6bc5b
@adamkendis
Added bulma-switch dependency and import.
0cce2f3
@adamkendis
Fixed Checkbox defaultProps.
e3a456d
@adamkendis
Generic toggleswitch component adhering to Bulma-switch extension sty…
a19c901 
…ling modifiers.
@adamkendis
Added leftLabel and rightLabel to ToggleSwitch props.
e832473
@adamkendis
Added id field to props and removed react-id-generator.
49e8403
@adamkendis
Removed react-id-generator from dependencies.
086a9c3
@adamkendis
Merge branch 'dev' into 180_FRONT_genericComponents
dbb98a5
@sellnat77
Copy link
Member

Branch name, pr message, nice work...🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥

brodly
brodly reviewed Jan 30, 2020
View reviewed changes
Copy link
Member

@brodly brodly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the id prop required or provide a default id if none is provided per our conversation on Tuesday?

brodly
brodly requested changes Jan 30, 2020
View reviewed changes
src/components/common/Button.jsx Outdated Show resolved Hide resolved
brodly
brodly approved these changes Feb 1, 2020
View reviewed changes
Copy link
Member

@brodly brodly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@brodly brodly merged commit 33f26ff into hackforla:dev Feb 1, 2020
@adamkendis adamkendis mentioned this pull request Feb 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brodly brodly brodly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adamkendis @sellnat77 @brodly