-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Design System #45
Comments
Started design system: https://www.figma.com/file/G5bOqhud6azbxyR9El9Ygp/Civic-Tech-Jobs?node-id=1%3A2 |
Let me know if these breakpoints will work? @Aveline-art and @arghmatey |
Hi @jenchuu ! I just reviewed the Figma and tried making a demo of the navbar. For the most part the breakpoints are fine, but one oddity I noticed is that the Figma designs are 1440px by width (x-large screens). Do you have any opinions on how the padding to the left of the logo, and the padding to the right of the button (see attached) should scale as the screen size shrinks from X-large to desktops? If not, can we use our best judgment to handle it? |
Hi @Aveline-art , would these breakpoints be better? Option 1 Option 2 |
@Aveline-art We designed desktop for 1440px width since that is the standard desktop frame for Figma and also suggested by HfLA's design system! |
@jenchuu There might have been some misunderstanding. I am perfectly fine with any breakpoints. From a development perspective, all I really need is to have an idea of where the breakpoints are so that we can work around it. You can feel free to set any points that you feel is best for you and your team. That being said, if you have a hard time deciding, these points that you sent us previously works perfectly fine for us.
For the padding, we will try our best then! |
@jenchuu , can you please edit this issue as needed |
Followed up with Lu for an update for if this issue is ready to move to the prioritized backlog. |
Closed this issue because the work has been completed. |
Dependency
Overview
As a designer, we need a design system to lay out standards and share with the dev team so they can build the website. We need to start creating components with states.
Action Items
Resources/Instructions
Reference HfLA's design system framework (once they complete it)
The text was updated successfully, but these errors were encountered: