Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Design System #45

Closed
8 tasks done
jenchuu opened this issue Nov 10, 2021 · 9 comments
Closed
8 tasks done

Create Design System #45

jenchuu opened this issue Nov 10, 2021 · 9 comments

Comments

@jenchuu
Copy link
Member

jenchuu commented Nov 10, 2021

Dependency

Overview

As a designer, we need a design system to lay out standards and share with the dev team so they can build the website. We need to start creating components with states.

Action Items

  • Create components and states
  • Discuss with dev team
  • Figure out best breakpoints
  • Discuss design system framework & best practices with HfLA's Design System team
  • Update design system to adhere to framework & best practices above

Resources/Instructions

Reference HfLA's design system framework (once they complete it)

@jenchuu jenchuu added role: UI/UX - Design size: 2pt Can be done in 7-12 hours size: 3pt Can be done in 31-48 hours and removed size: 2pt Can be done in 7-12 hours labels Nov 10, 2021
@jenchuu jenchuu self-assigned this Nov 16, 2021
@jenchuu
Copy link
Member Author

jenchuu commented Nov 17, 2021

@jenchuu
Copy link
Member Author

jenchuu commented Dec 1, 2021

Let me know if these breakpoints will work? @Aveline-art and @arghmatey
576px =< for mobile phones
577px-768px for tablets
769px-1024px for small screens, laptops
1025px-1200px for desktops, large screens
1201px => X-Large screens, TVs

@Aveline-art
Copy link
Member

Aveline-art commented Dec 6, 2021

Hi @jenchuu ! I just reviewed the Figma and tried making a demo of the navbar. For the most part the breakpoints are fine, but one oddity I noticed is that the Figma designs are 1440px by width (x-large screens). Do you have any opinions on how the padding to the left of the logo, and the padding to the right of the button (see attached) should scale as the screen size shrinks from X-large to desktops? If not, can we use our best judgment to handle it?

Padding

@jenchuu jenchuu added size: 3pt Can be done in 31-48 hours and removed size: 3pt Can be done in 31-48 hours labels Dec 9, 2021
@jenchuu
Copy link
Member Author

jenchuu commented Dec 9, 2021

Hi @Aveline-art , would these breakpoints be better?

Option 1
< 576px for XS
. >= 576px for S
. >= 768 for M
. >= 992px for L
. >= 1200px for XL
. >= 1400px for XXL
https://getbootstrap.com/docs/5.0/layout/breakpoints/

Option 2
<688px for mobile phones
688px-992px for tablets
993px-1312px for small laptops
. >1312px for desktops
https://coder-coder.com/media-query-breakpoints/

@jenchuu
Copy link
Member Author

jenchuu commented Dec 9, 2021

@Aveline-art We designed desktop for 1440px width since that is the standard desktop frame for Figma and also suggested by HfLA's design system!
Hmm I'm not too certain about padding. We designed it with 176px padding on the left and right (used 8pt system) so maybe scale by a multiple of 8? Please feel free to use your best judgment and expertise :)

@Aveline-art
Copy link
Member

@jenchuu There might have been some misunderstanding. I am perfectly fine with any breakpoints. From a development perspective, all I really need is to have an idea of where the breakpoints are so that we can work around it. You can feel free to set any points that you feel is best for you and your team.

That being said, if you have a hard time deciding, these points that you sent us previously works perfectly fine for us.

576px =< for mobile phones
577px-768px for tablets
769px-1024px for small screens, laptops
1025px-1200px for desktops, large screens
1201px => X-Large screens, TVs

For the padding, we will try our best then!

@sharadgaurav7
Copy link
Member

@jenchuu , can you please edit this issue as needed

@sharadgaurav7 sharadgaurav7 added the dependency This item depends on something label Apr 6, 2022
@kchotani kchotani removed the dependency This item depends on something label Mar 22, 2024
@kchotani
Copy link
Member

Followed up with Lu for an update for if this issue is ready to move to the prioritized backlog.

@kcoronel
Copy link
Member

kcoronel commented May 8, 2024

Closed this issue because the work has been completed.

@kcoronel kcoronel closed this as completed May 8, 2024
@ExperimentsInHonesty ExperimentsInHonesty added the PBV: design all issues for design roles label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

8 participants