Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug causing deployment to fail with Poetry version > 1.3.0 #458

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Bug causing deployment to fail with Poetry version > 1.3.0 #458

merged 2 commits into from
Oct 20, 2023

Conversation

alexlaw528
Copy link
Member

Fixes #457

Changes

  • Specify version of poetry to download at 1.3.0 as detailed here

@alexlaw528 alexlaw528 mentioned this pull request Oct 19, 2023
Closed
1 task
MattPereira

This comment was marked as duplicate.

Sign in to view

MattPereira
MattPereira reviewed Oct 19, 2023
View reviewed changes
dev/django.dockerfile Outdated
@@ -9,7 +9,7 @@ WORKDIR /code
SHELL ["/bin/bash", "-o", "pipefail", "-c"]

# Download Poetry into Path
RUN curl -sSL https://install.python-poetry.org | POETRY_HOME=/opt/poetry python3 -
RUN curl -sSL https://install.python-poetry.org | POETRY_HOME=/opt/poetry | POETRY_VERSION=1.3.0 python3 -
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with testing your hypothesis that the poetry version needs to be downgraded, but there may be a problem with the syntax

The CI checks shown at the bottom of PR are setup to prevent merging if any of them are failing

image

The linter thinks there's a problem with POETRY_HOME and POETRY_VERSION

https://github.com/hackforla/CivicTechJobs/actions/runs/6570541381/job/17848134099?pr=458#step:7:125

@MattPereira
Copy link
Member

closing and re-opening to re-run the CI checks just in case

@MattPereira MattPereira reopened this Oct 19, 2023
@bzzz-coding bzzz-coding self-requested a review October 19, 2023 20:04
bzzz-coding
bzzz-coding approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@bzzz-coding bzzz-coding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexlaw528 Thanks so much for working on this issue and fixing the linting error! Now that the PR passed all checks, please go ahead and merge it ✨

@alexlaw528 alexlaw528 merged commit 27d8621 into hackforla:main Oct 20, 2023
5 checks passed
alexlaw528 added a commit that referenced this pull request Oct 20, 2023
@alexlaw528
Revert "Bug causing deployment to fail with Poetry version > 1.3.0 (#458
b251eda 
)"

This reverts commit 27d8621.
@MattPereira MattPereira mentioned this pull request Oct 20, 2023
Merged
alexlaw528 added a commit that referenced this pull request Oct 21, 2023
@MattPereira @alexlaw528
Revert "Bug causing deployment to fail with Poetry version > 1.3.0 (#458
02aa4f7 
)" (#461)

This reverts commit 27d8621.

Co-authored-by: Alex Law <95406690+alexlaw528@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattPereira MattPereira MattPereira approved these changes

@bzzz-coding bzzz-coding bzzz-coding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix deployment workflow for staging site
3 participants
@alexlaw528 @MattPereira @bzzz-coding