Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename slack 1380 #1383

Merged
merged 2 commits into from
Apr 15, 2023
Merged

Conversation

plang-psm
Copy link
Member

Fixes #1380

What changes did you make and why did you make them ?

  • Rename the slack title in the add and edit projects form from 'SlackUrl' to 'Slack Channel Link'

** Field name was kept as SlackUrl due to how it is stored in MongoDB. This only changes the title users will see.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied image image
Visuals after changes are applied image image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b plang-psm-rename-slack-1380 development
git pull https://github.com/plang-psm/VRMS.git rename-slack-1380

@MattPereira MattPereira self-requested a review April 15, 2023 16:27
Copy link
Contributor

@MattPereira MattPereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with your assessment that it is best not to fuck with the project model schema field name for now

@MattPereira MattPereira merged commit 4905393 into hackforla:development Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Slack URL to Slack Channel Link on Add New Project Form
2 participants