Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Flashing error message on server error #1575

Merged

Conversation

freaky4wrld
Copy link
Member

@freaky4wrld freaky4wrld commented Feb 5, 2024

Fixes #1569

What changes did you make and why did you make them ?

  • Added a file name snackbarContext.js to client/src/context, the file is a context for the Snackbar component as per the requirement in the issue......
  • Removed the setEventAlert functionality and using Snackbar component added the functionality of adding alerts like
    - Event Created alert to recurring event
    - Event Updated alert when the recurring event is updated
    - Event Deleted alert when the recurring event is deleted

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Screenshot 2024-02-13 at 1 17 13 PM Screenshot 2024-02-13 at 1 17 37 PM Screenshot 2024-02-13 at 1 17 56 PM

Copy link

github-actions bot commented Feb 5, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b freaky4wrld-flash-error-message-on-alert-1569 development
git pull https://github.com/freaky4wrld/VRMS.git flash-error-message-on-alert-1569

@freaky4wrld
Copy link
Member Author

@Spiteless the alert on recurring event has been provided, please have a look, also please tell what to do whether to update alert for Event Updated/Event Deleted for severity=success or let it as it is ?

@Spiteless Spiteless marked this pull request as ready for review February 24, 2024 23:28
Copy link
Member

@Spiteless Spiteless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking very good. Thank you for your hard work!

Requested a few small changes to create more clarity.

Very close to merging!

client/src/components/manageProjects/editMeetingTimes.js Outdated Show resolved Hide resolved
client/src/components/manageProjects/editMeetingTimes.js Outdated Show resolved Hide resolved
@freaky4wrld
Copy link
Member Author

@Spiteless made the suggested changes, please check!!!

@Spiteless Spiteless merged commit 4d4825a into hackforla:development Feb 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide user a more clear flash message when errors happen
2 participants