remove popup on the close button

[josiehandeveloper]

Fixes ##1576

What changes did you make and why did you make them ?

• When the close button is pressed after the save button the "Wait! you made some changes" popup is removed
• Initial Fix got rid of the popup, but even when no edits were made on the form and then the close button was pressed - the popup persisted
• Final fix got rid of the popup after edits were made and the save button followed by the close button were pressed, it also got rid of the popup from the initial fix

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

1576.bug.mov

Visuals after changes are applied

1576.fix.mov

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b josiehandeveloper-Edit-on-save development
git pull https://github.com/josiehandeveloper/VRMS.git Edit-on-save

[trilliumsmith]

This is looking great :)

Works as intended, thanks Jo!

There's a lot of style based changes happening here that don't have much to do with the PR though, we don't have any enforced ESLint/Prettier. I'm fine if we include them but it would be better if the changes are their own commit rather than blocked together with the !editMode || ... code change so that future people can see the relevant info faster.

Can you:

• either:
  • switch the style changes to their own commit with a commit message like style: Update code styling in ProjectForm.js
  • Only commit the change directly relevant to the Close Edit Modal logic
• Delete the commented out code in the <StyledButton> tag

Thanks for figuring this out!

[josiehandeveloper]

I looked at the development branch to see what styling changes I made but I just changed the onClick portion of the code

[trilliumsmith]

It's because we don't have linting across the project at this time (it's in the works). Your linter is formatting the file you're working on when you trigger save probably, which is resulting in a lot of small changes to the code such as changing "thing" --> 'thing' etc. based on the linting rules your workspace has configured.

The file diff has a good representation of what's going on:
https://github.com/hackforla/VRMS/pull/1616/files

[trilliumsmith]

Thanks so much!