Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AdminDashboard component to use Material-UI Typography for h… #1677

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

chukalicious
Copy link
Member

@chukalicious chukalicious commented Jun 20, 2024

Fixes #1671

What changes did you make and why did you make them ?

  • the task required the change of regular html elements for their MUI equivalents, if applicable. Hence, I imported the Typography component from MUI and implemented it in place of the h1 component in the line 390. I implemented the variant and component properties as "h1".
  • It appears some formatting changes were also performed by my formatting extension.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied before
Visuals after changes are applied after

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b chukalicious-1671-update-html-components-to-mui-srccomponentsadmindashboardindexjs development
git pull https://github.com/chukalicious/VRMS.git 1671-update-html-components-to-mui-srccomponentsadmindashboardindexjs

@chukalicious chukalicious requested a review from jbubar June 20, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update HTML components to MUI: ./src/components/admin/dashboard/index.js
1 participant