Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add idp, oidc integration terraform configs #25

Closed
wants to merge 2 commits into from

Conversation

tylerthome
Copy link
Member

What changes did you make?

  • Add OIDC federated creds for incubator terraform action runners to Hack for LA AWS devops-security configurations

Rationale behind the changes?

  • Enable terraform operations from the main branch of the incubator repo (pending discussion)

Testing done for these changes

  • Terraform tested in separate account for new tf resources

What did you learn or can share that is new?(optional)

Notes

@tylerthome
Copy link
Member Author

@chelseybeck for your and team's review, I've included all of the relevant changes in a single top-level aws-identity-providers.tf file. I noticed that the aws-roles module can be modified to support the config needed for this OIDC update e.g. the federated principal in the policy definition. Happy to add that to this update, and/or factor this identity logic into a module if you foresee the team making this reusable.

@tylerthome
Copy link
Member Author

Closing in favor of #28

@tylerthome tylerthome closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant