Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWE Design System Components: Create shadow styles according to M3 #541

Closed
3 of 4 tasks
Tracked by #539
karina-sato opened this issue Feb 15, 2024 · 6 comments
Closed
3 of 4 tasks
Tracked by #539

Comments

@karina-sato
Copy link
Member

karina-sato commented Feb 15, 2024

Overview

We need to create the shadow styles according to M3 to be used consistently in different components of our Design System

Action Items

  • Use M3 Material Design guidelines to assess the style differences
  • Create the different levels and styles according to M3 and name them accordingly
  • Communicate changes in the issue's comments and with the design team
  • Close this issue

Resources/Instructions

@mklmrgn
Copy link
Member

mklmrgn commented Feb 22, 2024

See my sandbox here

Wrote basic guidelines for elevation styles and shadows using M3 guidelines. Created shadow styles for designers to use based on material specs and usage (Level 1 - Level 5).

Screen Shot 2024-02-22 at 8 15 22 AM Screen Shot 2024-02-22 at 8 15 12 AM Screen Shot 2024-02-22 at 8 15 44 AM

@karina-sato
Copy link
Member Author

Great @mklmrgn, tysm! Can you also create a microsite similar to the template below? We can have the different levels of elevations in Class. We don't need states, so instead, we can have Use Case and Examples of when to each.

image

@mklmrgn
Copy link
Member

mklmrgn commented Mar 6, 2024

@karina-sato
Copy link
Member Author

@mklmrgn update your progress here. If you are finished, add comment with updates and link to the master component + microsite. Unassign yourself, add tag "Ready for dev", move the issue to the question and review column. Don't forget to mark the Action Items.

@mklmrgn
Copy link
Member

mklmrgn commented Mar 18, 2024

Created Elevation shadow styles according to Material 3's style guide. Created a brief overview of how to use perceived elevation for UI. Defined different drop shadows for each elevation (i.e. level 1, level 2, etc) in order to have standardized way to create elevation effect using shadows.

Links to Style in Design System and Microsite

Screen Shot 2024-03-14 at 9 53 37 AM

@mklmrgn mklmrgn removed their assignment Mar 18, 2024
@mklmrgn mklmrgn moved this from In progress (actively working) to Questions/Review in TWE Project Management Mar 19, 2024
@joshfishman
Copy link
Member

approved thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants