Create table project_sponsor_partner_xref

[freaky4wrld]

Fixes #65 , #272

What changes did you make?

• Created a model for the ProjectSponsorPartnerXref
• Registered the model to adminSite
• Created API endpoints
• Renamed the model sponsor_partner to affiliate

Why did you make the changes (we will use this info to test)?

• To add a table ProjectSponsorPartnerXref in the database
• To make the model name shorter to affiliate

[fyliu]

Look great! Just a few things I noticed in the code should be changed.

[freaky4wrld]

@fyliu the changes you suggested are done, except the one with the is_sponsor one.

[fyliu]

Thanks for making the changes. I left another comment on the model and thought of something new. Can you take a look.

[freaky4wrld]

@fyliu the changes requested are done please check

[fyliu]

I'm realizing that this PR is essentially ready and is actually waiting for me.

We were discussing changes to it over slack chat. I'm pasting that here for reference

• updating the table name to project_affiliate_xref
• updating the model name to Affiliation, specifying that the db_table is the name above
• converting the boolean to an enum choice of sponsor or partner
• maybe also changing the sponsor_partner table name to affiliate and the FK field in Affiliation

I need to create issues for these and you can make any of the changes here you feel makes sense.

[freaky4wrld]

@fyliu I've made the suggested change, have a look and do resolve the issue I've mentioned in slack!!

[fyliu]

Thanks for the PR! The migrations applied fine for me.

There a few extra commits here that I think you brought over from main. They're making the github's PR changes view look more complicated. We should figure out how to make it cleaner for future PRs.

You made good assumptions with little information, but some of the things I just need to specify better. I think I need to create those other issues to better communicate what's needed.

[freaky4wrld]

@fyliu renamed the model and implemented Python Enums as per requirement, please check.

[fyliu]

Thanks for making the changes! I just found a couple small things that need changing.

[fyliu]

@freaky4wrld I just realized that the boolean to enum change hasn't been agreed on with @Neecolaa yet. Will have to bring that up for discussion in the next meeting.

[freaky4wrld]

@freaky4wrld I just realized that the boolean to enum change hasn't been agreed on with @Neecolaa yet. Will have to bring that up for discussion in the next meeting.

@fyliu did you had the discussion with @Neecolaa. I'm still waiting for the confirmation and further info on changes to be made!!

[Neecolaa]

We're adding a row:
is_partner is a boolean that indicated whether or not the given affiliate is a partner for the given project. Projects can now have an affiliate be both a partner and sponsor. We now have definitions for the affiliate types as well:
A Partner is an entity that's doing ongoing work with us on the project.
A sponsor is someone who has provided funds or an in-kind donation.

We won't be using an enum, just the two booleans.

[Neecolaa]

@freaky4wrld see update comment above

[freaky4wrld]

@fyliu and @Neecolaa the changes have been made as suggested, please check and provide feedback
Thanks

[fyliu]

Thanks for making the update and sorry for the change in requirement.

I found a couple things that could be improved. I'm short on time today so I'll continue tomorrow.

[fyliu]

Thanks for the updates.

I think I wasn't clear enough about the created_at field. It's already provided by the AbstractBaseModel and you just have to include it in the AffiliationSerializer. Can you remove it from the Affiliation model class. That should make it use the inherited one. Thank you!

[fyliu]

Works great, thanks!

I tried to simplify the commit history but it looks like I have to just squash them down to a single commit because of 2 models being changed. I also added a few other fixes that you can see at the end of the branch history in my forked branch