Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate System Design to Theme JSON + UI components #1341

Open
3 tasks done
shanesween opened this issue Mar 23, 2023 · 4 comments
Open
3 tasks done

Integrate System Design to Theme JSON + UI components #1341

shanesween opened this issue Mar 23, 2023 · 4 comments
Labels
Dependency Issues that cannot be worked on until another issue is closed enhancement Release Note: Shows as visual or user experience Enhancement feature: UI Cleanup & Documentation level: medium pbv: dev All engineering issues priority: SHOULD HAVE role: front-end Front End Developer size: missing
Milestone

Comments

@shanesween
Copy link
Member

shanesween commented Mar 23, 2023

Dependency

Overview

This ticket will track the integration of the new system design as well as the use of the theme across multiple instances of inconsistencies in the UI components.

Action Items

  • Add new design systems to theme.js
  • Add new theme properties to the JSS objects in each components.
    • Typography
    • Color Palette
      • Convert all Negative Icons ('#E46247') to Error/Warning ('#B64E38')
  • Below are all of the inconsistencies in the Figma file that need to be addressed: To be added.
    • Login
      • Error
    • Create Project:
      • Page 1
      • Page 3
      • Page 3 Error
      • Page 2 & 4 TBD

Resources/Instructions

@shanesween shanesween self-assigned this Mar 23, 2023
@shanesween shanesween added the role: front-end Front End Developer label Mar 23, 2023
@shanesween
Copy link
Member Author

shanesween commented Mar 23, 2023

@Noushie
Copy link
Member

Noushie commented Apr 15, 2023

Hey @shanesween, so sorry to bother you!

I just noticed while on the dev version of the site, I'm concerned the disablement of buttons weren't super clear. I was wondering if the entire button could also be lowered in opacity, not merely the icons/text - that way there's more of a distinctive difference between the disabled and enabled states.

I can definitely add a lighter shade of green for the disabled state into the design system, if that is easier.

Thanks again

@Biuwa
Copy link
Member

Biuwa commented May 6, 2023

@Biuwa Biuwa added the Dependency Issues that cannot be worked on until another issue is closed label May 13, 2023
@Biuwa Biuwa closed this as completed Jun 8, 2023
@fnaneberhane fnaneberhane reopened this Aug 17, 2023
@fnaneberhane
Copy link
Member

Dev team will add more action items to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependency Issues that cannot be worked on until another issue is closed enhancement Release Note: Shows as visual or user experience Enhancement feature: UI Cleanup & Documentation level: medium pbv: dev All engineering issues priority: SHOULD HAVE role: front-end Front End Developer size: missing
Projects
Status: Prioritized Backlog
Development

No branches or pull requests

5 participants