Added inline if-else to remove click function and hover pointer class

[irisslee]

Fixes ##1552

What changes did you make?

• Added inline if else to remove click function (one that sorts) and hover pointer class

Why did you make the changes (we will use this info to test)?

• Because the last column shouldn't sort or change pointer on hover

Issue-Specific User Account

If you registered a new, temporary TDM User Account for this issue, indicate the
username (i.e., email address) for the account.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Visuals after changes are applied

[ZekeAranyLucas]

nice getting this in a PR so fast! :)

[ZekeAranyLucas]

what does 8 mean?

this feels fragile, the design folks keep changing the required columns. consider structuring it to make it clearer why this code is needed.

[irisslee]

tdm-calculator/client/src/components/Projects/ProjectsPage.js

Lines 366 to 385 in 8c0d6bc

	const headerData = [
	{
	id: "dateHidden",
	label: "Visibility"
	},
	{
	id: "dateSnapshotted",
	label: "Status"
	},
	{ id: "name", label: "Name" },
	{ id: "address", label: "Address" },
	{ id: "VERSION_NO", label: "Alternative Number" },
	{ id: "firstName", label: "Created By" },
	{ id: "dateCreated", label: "Created On" },
	{ id: "dateModified", label: "Last Modified" },
	{
	id: "contextMenu",
	label: ""
	}
	];

The function iterates through this list of headers and adds classes and click functions. I'm just using the index on this list of headers. I agree that it's fragile! Another option would be to add conditional based on label being blank string, or maybe we can add a boolean property to this header list.... something like - "sortfunction": true/false and base the conditionals off of that. I prefer the latter - I think it's more explicit. What do you think?

[entrotech]

Instead of

<td
  key={i}
  className={
    i == 8
...

, it might be safer to write

<td
  key={h.id}
  className={
    h.id === "contextMenu"
...

and you wouldn't need to use the index i at all, since the purpose of the id property is to uniquely identify each column heading. This would be fairly robust with respect to future changes that might re-arrange colums.

[irisslee]

@entrotech @ZekeAranyLucas Here are my changes - 38a527c
instead of using column index, it uses explicit name "contextmenu"

[ZekeAranyLucas]

much clearer! ship it