1710 saving new project bug #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1710
What changes did you make?
modified the "navigate away" line on save for new projects to point toward a different variable.
Changed the check for the popup modal to NOT trigger if the page the user is navigating away from is has a project id of 0.
Why did you make the changes (we will use this info to test)?
When navigating to a new path on save, the navigation function now grabs the correct page number, so it should navigate users back to the same page they saved on, rather than a "N/A" page number.
The popup modal was triggered by url change from a project with no id number (such as from a new project) to a project with an id number. I set the modal to not trigger if the first url had no project id number.
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
