Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1701 sibling page for items in my project #1740

Merged
merged 18 commits into from
Jun 18, 2024

Conversation

akinevans
Copy link
Member

@akinevans akinevans commented Jun 13, 2024

Fixes #1701

What changes did you make?

  • Implement ability to choose how many page links are visible in the Pagination component via props
  • Implement functionality to always display first and last page links
  • Remove the navigate to last / first page buttons as they became redundant.

Why did you make the changes (we will use this info to test)?

  • Completing an issue (# 1701)

Issue-Specific User Account

If you registered a new, temporary TDM User Account for this issue, indicate the
username (i.e., email address) for the account.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

…ayProjectPageLinks to handle correct pagination
…ks to load incorrectly when current selected page is within 2 pages of the first or last page.
…unction to return list elements containing appropriate links. Update comments
…unt of data by calling displayPerimeterPages before the li elements are rendered
…into 1701-sibling-page-for-items-in-my-project

Merge latest develop branch code into branch 1701 to fix any potential merge conflicts locally
@entrotech entrotech merged commit 87e1b5a into develop Jun 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sibling page for the items per page in My Project
2 participants