Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update new developer checklist #3254

Closed
1 task
angietechcafe opened this issue Jun 16, 2022 · 10 comments
Closed
1 task

Update new developer checklist #3254

angietechcafe opened this issue Jun 16, 2022 · 10 comments
Labels
Feature: Onboarding/Contributing.md good first issue Good for newcomers Ignore: No longer planned role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Comments

@angietechcafe
Copy link
Member

angietechcafe commented Jun 16, 2022

Overview

As a new developer, I would like instructions to be more clear. For this issue, we will update the Developer Prework Checklist.

Action Items

  • Add a line there that says these steps can be completed in any order

Resources/Instructions

@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Jun 16, 2022
@github-actions

This comment was marked as outdated.

@ExperimentsInHonesty ExperimentsInHonesty added this to New Issue Approval in Project Board via automation Jun 23, 2022
@JessicaLucindaCheng JessicaLucindaCheng added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers and removed role missing labels Jul 11, 2022
@ExperimentsInHonesty ExperimentsInHonesty added Feature: Onboarding/Contributing.md and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. labels Sep 11, 2022
@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Sep 11, 2022

@angieintech Where in the dev prework template file do you think the text about the steps could be completed in any order should go.

After you have answered, please add the ready for dev lead label to this issue and remove the draft label

@ExperimentsInHonesty ExperimentsInHonesty added Size: Good second issue size: 0.25pt Can be done in 0.5 to 1.5 hours Draft Issue is still in the process of being created and removed size: missing labels Sep 11, 2022
@kathrynsilvaconway
Copy link
Member

@ExperimentsInHonesty @JessicaLucindaCheng @blulady @arpitapandya @SAUMILDHANKAR
Can we take a quick vote on whether or not this addition to the prework remplate is necessary? Currently, under the special notes section, point 3 says:

"The action items listed below should mostly be worked on in a sequential order. However, you don't have to wait on one if you can proceed with the others, For instance, you don't have to wait for attending a weekly meeting before setting up your dev environment."

Does that seem clear enough?

@arpitapandya
Copy link
Member

arpitapandya commented Sep 13, 2022

If I focus what's under Action Items? Yes, sequential order matters. Whereas, the second line depends on what the new dev thinks what's important in it to follow in sequence, as I am aware that there're few list of actions that they complete while Onboarding meeting and thenafter they checkmark whether they already completed(for eg. slack, GitHub handle, figma). The third line example(meeting) seems relevant.

Or If we wanna separate the above checklist from Action Items. That may help to let the dev finish all the 32 tasks to close their Pre-work checklist and not re-opening for them of missing something.

It's just my thought.

Also, attaching this as this is a separate topic

(Is this new template? The first 3 lines are mandatory (*) and no checkbox and indented though it's a start of action items.)
whyisthisdifferent

I am seeing different pre-work checklist open with 32, 33 and 34 tasks in total.

@JessicaLucindaCheng
Copy link
Member

@ExperimentsInHonesty @JessicaLucindaCheng @blulady @arpitapandya @SAUMILDHANKAR
Can we take a quick vote on whether or not this addition to the prework remplate is necessary? Currently, under the special notes section, point 3 says:

"The action items listed below should mostly be worked on in a sequential order. However, you don't have to wait on one if you can proceed with the others, For instance, you don't have to wait for attending a weekly meeting before setting up your dev environment."

Does that seem clear enough?

@kathrynsilvaconway I think that's clear. However, I'm not a new developer and it might be confusing or unclear for new developers. I suggest asking the junior developers on the team about it during a meeting.

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Nov 6, 2022

Next steps on this issue is to bring this up at the next meeting with the dev team and take a quick vote on whether or not the suggested change in this issue is needed in the prework template?

Currently, under the special notes section, point 3 says:

"The action items listed below should mostly be worked on in a sequential order. However, you don't have to wait on one if you can proceed with the others, For instance, you don't have to wait for attending a weekly meeting before setting up your dev environment."

Does that seem clear enough?

@JessicaLucindaCheng
Copy link
Member

@jdingeman I saw you brought this up in the meeting yesterday. Did you all vote on whether the suggested change in #3254 (comment) is needed in the prework template? Or is it already clear enough with:

...under the special notes section, point 3 says:

"The action items listed below should mostly be worked on in a sequential order. However, you don't have to wait on one if you can proceed with the others, For instance, you don't have to wait for attending a weekly meeting before setting up your dev environment."

@jdingeman
Copy link
Member

@JessicaLucindaCheng we hadn't taken a vote but we asked the devs to look over the issue and let us know since not everyone was at the meeting. Personally, I think it is already clear enough with the way that statement is written. We have had new devs ask us before if they need to complete one step before the other, and with this, I don't imagine they would question it and they can move on with their tasks.

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Nov 13, 2022

@jdingeman If you think we don't need to implement this issue because the info in the developer checklist is clear enough, then please

  • Close this issue with a comment on why we are not implementing this issue
  • Also, add an appropriate Ignore label

Edit: I added a ready for dev lead label since this issue requires a dev lead to decide if this is needed.

@JessicaLucindaCheng JessicaLucindaCheng added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Dec 3, 2022
@plang-psm
Copy link
Member

Closing out as the dev team plans to keep the checklist as is.

Project Board automation moved this from New Issue Approval to QA Dec 6, 2022
@ExperimentsInHonesty ExperimentsInHonesty moved this from QA to Done in Project Board Jan 8, 2023
@ExperimentsInHonesty ExperimentsInHonesty removed the Draft Issue is still in the process of being created label Jan 8, 2023
@ExperimentsInHonesty ExperimentsInHonesty removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Onboarding/Contributing.md good first issue Good for newcomers Ignore: No longer planned role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Project Board
  
Done
Development

No branches or pull requests

7 participants