-
-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create script to check project files for missing data #386
Comments
I'm just getting over some pretty bad food poisoning so I haven't worked on this as much as I would have liked. I still need to make a 100 Automation's repo to continue developing my python script. Action Item Progress
I have chosen to stick to a spreadsheet for the desired output of our script. I'm currently outputting a spreadsheet that contains two columns, one for the name of the project and the other for the list of missing data types. The data types that we are using are currently hard coded in the script and were obtained by using a script that collected a set of used data types across all projects. Note: I'm currently not taking account of nested data types. For example name, role, and links that are under "Leadership" in the following image. This is something I want to look in to, but I might have to reconsider how I deal with my output and determine what nested data types are important. |
Added 100Automations repo. https://github.com/100Automations/script-gather-missing-data-types |
@ExperimentsInHonesty will talk to @rblaz001 about topic tags |
@rblaz001 Please fill this out, so that we can get you listed on the 100automations.org site that will soon exist: |
Spreadsheet for current unused/missing data types. Note: Unused Data Types are data types that are never used in a project card. Missing Data Types are nested data types that are missing even though the parent data types are present. (This can be one or more instances) |
Notes From Bonnie:
|
@rblaz001 do you have a list of all the data types? If so, can you upload to google drive and share the link here? |
@alexandrastubbs I have to make a small adjustment to the script to output all the currently used data types. I'm not home at the moment but I'll be able to upload the file and link it before tomorrow morning. |
@alexandrastubbs I added an extra sheet labeled "Used Data Types" that has a list of data types used across the project cards. https://docs.google.com/spreadsheets/d/1w59UfwbGiEAoBXjAxl4uwQe3xk5j6yFd3NxBMOm510Y/edit?usp=sharing Note: The data types are not ordered. Also comma separated data types represent the nesting
|
Progress Report
Work In Progress Finishing refactor documentation: Then working on validate through template feature: Was also able to look in to github action api and it should be possible to automate issues for missing data types relatively easy. The only blocker I'm having right now is thinking through how to manage issues so redundant issues are not created. |
@rblaz001 to rename from 'used data types' to 'all data types' |
Progress - My availability changed this last week, I was unable to get any work done Priority:
Task after priority finished:
|
@rblaz001 checking to see if you are able to put in an update on this issue before tomorrow. |
Progress
Next step is to add validate through template.
Then begin work on implementing GitHub actions Blockers - Moving to Austin, still trying to find an apartment so I have very limited time Availability - Limited |
Do UX requirement gathering. |
template.md
|
Updated Project Card Data Types - 9/13/2020 Updated Template Data Types - 9/13/2020 |
What are the items like:
|
ah.. my bad... let me work on a bit more detailed error report. |
Edited #386 (comment) , to give a bit more detailed report. "error":[
{
"message": "is not of type string",
"expected": "string",
"given": "null",
"stack": "on line 256 ,in 'message': null"
}
]
but can't seem to find the relevant information... :( |
"looking" (and probably "technologies") can be empty. Can you express that in a json schema? optional fields can exist but be empty? |
yewp, not a problem. I can make the looking be either string/null . But a project should always at least have technology, no?? I would be hesitant on allowing that to be empty... |
Updated - > #386 (comment) |
Currently I have a
Require feedback on where you want to go next with this @cnk? @ExperimentsInHonesty ? My Proposal
Example Issue that would be created : Project Validation Failing[month/date/year]OverviewThe following report was generated due to project schema not matching validation schema. Please review the report listed below under Project Validation Error Report[
{
"file": "100 Automations",
"errors": [
{
"message": "requires property \"partner\"",
"stack": "instance requires property \"partner\""
},
{
"message": "requires property \"tools\"",
"stack": "instance requires property \"tools\""
}
]
},
{
"file": "311 Data",
"errors": [
{
"message": "requires property \"tools\"",
"stack": "instance requires property \"tools\""
}
]
}
] Action Items
Resources/Instructions |
@akibrhast I like the proposal.
Interested to hear your suggestions for improvement based on these concerns. |
Currently the schema is created based on this comment #386 (comment) ('Current Project Must Have's') . According to that comment, all current projects must have those keys. However it seems like if you look at the image below that key is commented out for some reason. https://raw.githubusercontent.com/hackforla/website/gh-pages/_projects/100-automations.md . That should not be the case, it's fine if the partner value is empty, but key should still exist. According to the original issue Action Item #386 (comment)
Some details that needs to be consolidated are
Same questions apply to Completed Projects and On Hold Projects. Changing the schema is relatively simple. As you can see, a comment by @cnk #386 (comment) was made and the schema was soon changed after that.
Maybe generate a single issue per file ? |
ProgressNone since 5 days ago BlockersAwaiting Feedback from @ExperimentsInHonesty @cnk AvailabilityHere and There ETAN/A |
Met with @akibrhast - he will add notes to this doc. |
Overview
We need an easy way of finding out when data is missing from project cards so that we can present an uniform UX and so that functions that rely on this data can work across all projects.
Action Items
Requirements
The text was updated successfully, but these errors were encountered: