Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit documentation: DR: img tag #4363

Open
1 of 4 tasks
JessicaLucindaCheng opened this issue Apr 1, 2023 · 12 comments · Fixed by hackforla/website-wiki#8
Open
1 of 4 tasks

Edit documentation: DR: img tag #4363

JessicaLucindaCheng opened this issue Apr 1, 2023 · 12 comments · Fixed by hackforla/website-wiki#8
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Dependency An issue is blocking the completion or starting of another issue Feature: Wiki role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Apr 1, 2023

Dependency

Overview

We need to edit a decision record DR: img tag so that it has content that is helpful in understanding our standards for img HTML tags.

Action Items

Resources/Instructions

@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing labels Apr 1, 2023
@hackforla hackforla deleted a comment from github-actions bot Apr 1, 2023
@JessicaLucindaCheng

This comment was marked as outdated.

@JessicaLucindaCheng JessicaLucindaCheng added Feature: Wiki Complexity: Small Take this type of issues after the successful merge of your second good first issue labels Apr 2, 2023
@JessicaLucindaCheng JessicaLucindaCheng added this to New Issue Approval in Project Board via automation Apr 2, 2023
@JessicaLucindaCheng JessicaLucindaCheng added role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours size: 0.5pt Can be done in 3 hours or less and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 2, 2023
@JessicaLucindaCheng JessicaLucindaCheng changed the title Add to Wiki: Edit Wiki page: DR: img tag Apr 2, 2023
@JessicaLucindaCheng JessicaLucindaCheng changed the title Edit Wiki page: DR: img tag Edit Wiki page: DR: img tag Apr 2, 2023
@JessicaLucindaCheng JessicaLucindaCheng added the Draft Issue is still in the process of being created label Apr 2, 2023
@JessicaLucindaCheng JessicaLucindaCheng self-assigned this Apr 2, 2023
@github-actions

This comment was marked as resolved.

@JessicaLucindaCheng JessicaLucindaCheng removed the Draft Issue is still in the process of being created label Apr 2, 2023
@JessicaLucindaCheng JessicaLucindaCheng removed their assignment Apr 2, 2023
@JessicaLucindaCheng JessicaLucindaCheng added the Dependency An issue is blocking the completion or starting of another issue label Apr 2, 2023
@JessicaLucindaCheng JessicaLucindaCheng moved this from New Issue Approval to Ice box in Project Board Apr 2, 2023
@JessicaLucindaCheng JessicaLucindaCheng changed the title Edit Wiki page: DR: img tag Edit documentation: DR: img tag Apr 2, 2023
@JessicaLucindaCheng

This comment was marked as resolved.

@github-actions

This comment was marked as outdated.

@JessicaLucindaCheng
Copy link
Member Author

JessicaLucindaCheng commented May 28, 2023

  • Since Vanessa (GitHub: vraer) already added the updated decision record as part of the pr Refactor Decision Record directory structure and file names website-wiki#8, I went ahead and assigned Vanessa to this issue since she basically completed the work for this issue.
  • I know this bypasses the dependencies in the issue but I think this is okay. I had put the dependencies thinking that a junior developer would eventually make the edits. However, since Vanessa is a team lead and already added it as part of her pr, I think this issue is completed.

This comment was marked as resolved.

@ExperimentsInHonesty ExperimentsInHonesty moved this from QA to In progress (actively working) in Project Board Jan 30, 2024
Project Board automation moved this from In progress (actively working) to New Issue Approval Jan 30, 2024
@ExperimentsInHonesty

This comment was marked as resolved.

@JessicaLucindaCheng

This comment was marked as resolved.

@JessicaLucindaCheng
Copy link
Member Author

JessicaLucindaCheng commented Feb 4, 2024

Issue

None

Problem Statement

In our codebase, we are not consistent with whether we apply an ending slash for img HTML tags.

Example of code with <img...>:

<img src="/assets/images/404.svg" alt="404">

Example of code with <img.../>

<img class="donate-banner-icon" src="/assets/images/donate/solidarity-pana.svg" alt="" />

Potential Solution

Use the img HTML tag without an ending slash meaning <img...> (Source 1).

Feasibility Determination

This is feasible because we only use HTML. An ending slash in an img tag is needed for XHTML and XML (Source 2), which we don't use.

Sources

  1. https://html.spec.whatwg.org/multipage/embedded-content.html#the-img-element
  2. https://stackoverflow.com/a/15149657

@JessicaLucindaCheng
Copy link
Member Author

JessicaLucindaCheng commented Feb 4, 2024

@ExperimentsInHonesty

@JessicaLucindaCheng will revise the draft in a comment below and then add this to the list of pages that need to get added to the wiki, keeping in mind that its actually a re-write

@JessicaLucindaCheng JessicaLucindaCheng removed their assignment Feb 4, 2024
@JessicaLucindaCheng JessicaLucindaCheng moved this from New Issue Approval to Ice box in Project Board Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Dependency An issue is blocking the completion or starting of another issue Feature: Wiki role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Project Board
  
Ice box
Development

Successfully merging a pull request may close this issue.

3 participants