Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DR: Write a Decision Record for the styling of the executive letter #4426

Closed
7 of 8 tasks
jdingeman opened this issue Apr 6, 2023 · 10 comments
Closed
7 of 8 tasks

DR: Write a Decision Record for the styling of the executive letter #4426

jdingeman opened this issue Apr 6, 2023 · 10 comments
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: About Us https://www.hackforla.org/about/ role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Milestone

Comments

@jdingeman
Copy link
Member

jdingeman commented Apr 6, 2023

Overview

The Letter from the Executive currently exists on a page card that has squared corners. Most of the other cards across the website have rounded corners. We need a Decision Record to document this choice in design.

Corners of the Letter from the Executive

image

Corners of other cards

image

Action Items

  • We are currently in the process of moving the old wiki to the new website-wiki repo, so we will not be making any changes or additions to the old wiki at this time. Thus, we will be adding wiki content through a different process now. Read How to Contribute to the Wiki

Action Items to be completed when new wiki is ready

  • Create a new Decision Record for Solutions Adopted named "DR: Card with the Letter on About page has square edges"
  • Document the reasoning behind making it so the Letter has squared edges instead of rounded edges
    • The reasoning is that we want the Letter to look like a real letter - this includes its formatting and that it will have a signature at the bottom.
    • It's the only card on the site with square edges, but there is a possibility that the card style may be used again.
  • Go back to the Decision Records for Solutions Adopted page and add a link to this new article
  • Go back to the Decision Records homepage and add a link to the article preceded by a ✅
  • When you have completed this, review your work with Bonnie

Resources/Instructions

Decision Records Template
This is a record in the [Decision Records on Solutions Adopted](https://github.com/hackforla/website/wiki/Decision-Records-on-Solutions-Adopted).

#### Issue 
#### Problem Statement
#### Potential Solution
#### Feasibility Determination
@jdingeman jdingeman added role: front end Tasks for front end developers P-Feature: About Us https://www.hackforla.org/about/ Complexity: Small Take this type of issues after the successful merge of your second good first issue Ready for Prioritization size: 0.5pt Can be done in 3 hours or less labels Apr 6, 2023
@jdingeman jdingeman added this to the 05. Know HFLA milestone Apr 6, 2023
@jdingeman jdingeman added this to New Issue Approval in Project Board via automation Apr 6, 2023
@jdingeman

This comment was marked as outdated.

@ExperimentsInHonesty

This comment was marked as outdated.

@ExperimentsInHonesty ExperimentsInHonesty added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed ready for product labels Apr 6, 2023
@JessicaLucindaCheng

This comment was marked as outdated.

@JessicaLucindaCheng

This comment was marked as outdated.

@jdingeman jdingeman added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Apr 10, 2023
@ExperimentsInHonesty ExperimentsInHonesty moved this from New Issue Approval to Prioritized backlog in Project Board Apr 30, 2023
@ldietz08 ldietz08 self-assigned this Jun 2, 2023
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Hi @ldietz08, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@ldietz08 ldietz08 moved this from Prioritized backlog to In progress (actively working) in Project Board Jun 2, 2023
@ldietz08
Copy link
Member

ldietz08 commented Jun 2, 2023

Availability: 6/2-6/4 11am-3pm
ETA: 6/3

@ldietz08
Copy link
Member

ldietz08 commented Jun 4, 2023

This is a record in the Decision Records on Solutions Adopted.

Issue

Problem Statement

Ensure that the corners of the Letter from the Executive page remain square to retain the visual characteristics of a traditional letter.

Corners of the Letter from the Executive

image

Corners of other cards

image

Potential Solution

We want to maintain the square corners on the Letter from the Executive page so it resembles a letter with proper formatting and a signature. The square corners aligns with the formal and structured design of a traditional letter.

ER associated with this issue: #4367

@ldietz08 ldietz08 moved this from In progress (actively working) to Questions / In Review in Project Board Jun 4, 2023
@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Jun 11, 2023

@ldietz08 Good work on the Decision Record. Its ready to add to our store of changes we will be making to the wiki. Please see the action item that is unchecked above

  • We are currently in the process of moving the old wiki to the new website-wiki repo, so we will not be making any changes or additions to the old wiki at this time. Thus, we will be adding wiki content through a different process now. Read How to Contribute to the Wiki

And do the instructions in that wiki page it references to add this DR to the list of items we will add to the wiki once the new wiki is totally live.

@ExperimentsInHonesty ExperimentsInHonesty moved this from Questions / In Review to In progress (actively working) in Project Board Jun 11, 2023
@ldietz08
Copy link
Member

I added a link to my comment under the Content to be Added/Edited in the New website-wiki Repo section.

@ldietz08 ldietz08 moved this from In progress (actively working) to Questions / In Review in Project Board Jun 18, 2023
@roslynwythe
Copy link
Member

Thank you @ldietz08 for adding that link to your comment, so that it will be incorporated into the wiki once it is ready.

Project Board automation moved this from Questions / In Review to QA Jun 21, 2023
@ExperimentsInHonesty ExperimentsInHonesty moved this from QA to Done in Project Board Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: About Us https://www.hackforla.org/about/ role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Project Board
  
Done
Development

No branches or pull requests

5 participants