-
-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"How to Review Pull Requests" Guide: Update Step 0 to Include Pull Request Branch Review #4662
Comments
Hi @93Belen, thank you for taking up this issue! Hfla appreciates you :) Do let fellow developers know about your:- You're awesome! P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :) |
Availability: Tuesday, Friday and Sunday from 6am to 6pm |
Step 0: Is the pull request done with the correct branch?Before anything else, check that the pull request contains the correct branches. In other words, it must pass the following three checks:
If any of the criteria isn't met, then the collaborator might have made a mistake when making their pull request. Leave a comment stating the problem with their pull request and to redo the pull request per the criteria. |
@hackforla/website-merge Hi! I commented the wiki page with my changes here: #4662 (comment) Than you! |
Hi @93Belen, thank you for working the issue! The issue was correctly linked in the How to Contribute to the Wiki guide and the content of the wiki page update was correctly commented in this issue. Could you perform the following:
|
No need to do anything for this comment. For documentation purposes only. The copy of the wiki page above contains broken links to images not in Step 0. This due to the relative links in the |
Availability: Sunday, Monday and Tuesday from 6am to 5pm |
@Adastros Hi! thanks for the clarification!
|
Hi @93Belen, thank you for implementing the updates! The step 0 image and text instructions are clean and clear. For the details summary, you can replace the entire URL with a relative link ( |
@Adastros you are right, it worked! thanks! |
Hi @93Belen, thank you for working on this issue and implementing the changes! The Step 0 instructions and image are clean, clear, and align with the from branch naming instructions in CONTRIBUTING.md. Feel free to pick up a large issue! Closing this issue and moving it to the QA section of the project board. |
Overview
We want to ensure that our contributing and review processes align with each other. In this issue, we need to update Step 0 of the "How to Review Pull Requests" Guide to include instructions to verify that the pull request branch name matches the branch naming scheme in the
CONTRIBUTING.md
guide.Action Items
Resources/Instructions
The text was updated successfully, but these errors were encountered: