Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER: Fix mail links in "Privacy Policy" #7108

Closed
4 of 7 tasks
t-will-gillis opened this issue Jul 14, 2024 · 9 comments
Closed
4 of 7 tasks

ER: Fix mail links in "Privacy Policy" #7108

t-will-gillis opened this issue Jul 14, 2024 · 9 comments
Assignees
Labels
Bug Something isn't working Complexity: Small Take this type of issues after the successful merge of your second good first issue ER Emergent Request Issue Making: Level 2 Make issue(s) from an ER or Epic P-Feature: Privacy Policy https://www.hackforla.org/privacy-policy role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less time sensitive Needs to be worked on by a particular timeframe

Comments

@t-will-gillis
Copy link
Member

t-will-gillis commented Jul 14, 2024

Emergent Requirement - Problem

The mail links on the "Privacy Policy"1 page are broken, and send users to a "something went wrong" page. We need to fix three links on this page so that we receive emails from visitors.

Result of clicking on mail link Screenshot 2024-07-14 133152
### Issue you discovered this emergent requirement in - #7107

Date discovered

7/14/24

Did you have to do something temporarily

  • YES
  • NO

Who was involved

@t-will-gillis, @ anitahammer (outside HfLA)

What happens if this is not addressed

The page is asking for the reader to send an email to notify us of potential problems, but the link does not work. We might not be receiving emails from readers of this page.

Recommended Action Items

  • Make a new issue
  • Discuss with team
  • Let a Team Lead know

Potential solutions [draft]

In the privacy-policy.yml2 document, there are three locations (around lines 70, 80, and 92) where we indicate that users can contact us by email.

  • For each location, replace:
    [privacy@hackforla.org](privacy@hackforla.org)
    
    with:
    [privacy@hackforla.org](mailto: privacy@hackforla.org)
    
  • Using Docker, verify that the links direct users to their default email.

Resources

Footnotes

  1. Privacy Policy

  2. privacy-policy.yml

@t-will-gillis t-will-gillis added Bug Something isn't working role: front end Tasks for front end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Privacy Policy https://www.hackforla.org/privacy-policy size: 0.5pt Can be done in 3 hours or less Issue Making: Level 2 Make issue(s) from an ER or Epic ER Emergent Request Ready for Prioritization labels Jul 14, 2024
@ExperimentsInHonesty ExperimentsInHonesty added this to the 01. Compliance milestone Jul 16, 2024
@ExperimentsInHonesty ExperimentsInHonesty added time sensitive Needs to be worked on by a particular timeframe and removed Ready for Prioritization labels Jul 16, 2024
@dcotelessa dcotelessa self-assigned this Aug 25, 2024
@HackforLABot
Copy link
Contributor

Hi @dcotelessa, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@dcotelessa
Copy link
Member

Availability: Sun 11:00-3pm, Tue-Wed: 3-5
ETA: 2 hours

@dcotelessa
Copy link
Member

Issue Created:

#7410
#7411
#7412

@dcotelessa dcotelessa added the ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization label Sep 8, 2024
@t-will-gillis
Copy link
Member Author

Hey @dcotelessa! Woohoo thanks for working on these- they look good. Just a couple suggestions:

  • I think the issue titles will read better if the "7108: " is removed for each
  • I like to give the link to the actual file, either in the body of the issue or in "Resources/Instructions", e.g. "- privacy-policy.yml" Just to make it easier for whoever works on it
  • Could you capitalize "Docker" ?
  • I like that you are emphasizing the location of the change and that the change applies only to the section noted

@t-will-gillis t-will-gillis removed the ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization label Sep 9, 2024
@jphamtv
Copy link
Member

jphamtv commented Sep 12, 2024

Hi @dcotelessa -

Additional suggestions:

  • Fix typo: 'privacy-policy.yml.file' should be 'privacy-policy.yml file'
  • Add project webpage URL under Resources (as per last action item)

Once you've made these and @t-will-gillis's edits:

  1. Remove 'Draft' label
  2. Add 'ready for merge team' label

The team will then re-review. Thanks!

--

@t-will-gillis - Since these are split into three separate issues in the same file, should we relabel them as 'good first issues'? Or consolidate them into one issue if we want to keep it as a small complexity issue? Thoughts?

@dcotelessa
Copy link
Member

Hey @dcotelessa! Woohoo thanks for working on these- they look good. Just a couple suggestions:

  • I think the issue titles will read better if the "7108: " is removed for each
    Updated titles.
  • I like to give the link to the actual file, either in the body of the issue or in "Resources/Instructions", e.g. "- privacy-policy.yml" Just to make it easier for whoever works on it
    Added footnotes.
    Sounds good!
  • Could you capitalize "Docker" ?
    Updated
  • I like that you are emphasizing the location of the change and that the change applies only to the section noted

@dcotelessa dcotelessa added the ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization label Sep 12, 2024
@t-will-gillis
Copy link
Member Author

t-will-gillis commented Sep 13, 2024

@dcotelessa looks good- thanks for making all of the changes.
@jphamtv about these issues' complexities: I agree that split into three, this is more like good first issues and that as one issue it would be Complexity: Small.

Ugh- the (not great) counter argument is to leave these as Complexity: Small since we need more small issues.

@dcotelessa
Copy link
Member

Let me know if we want to label as good first issues, but for now they are set to Complexity: Small and close this IM.

@t-will-gillis t-will-gillis removed the ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization label Sep 13, 2024
@t-will-gillis
Copy link
Member Author

Hey @dcotelessa Thanks, the issues look great and are prioritized-

Closing this issue as successfully completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Complexity: Small Take this type of issues after the successful merge of your second good first issue ER Emergent Request Issue Making: Level 2 Make issue(s) from an ER or Epic P-Feature: Privacy Policy https://www.hackforla.org/privacy-policy role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less time sensitive Needs to be worked on by a particular timeframe
Projects
Development

No branches or pull requests

5 participants