Refactor of Wins Page Button #2918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sparky-code
added this to PR Needs review (Automated Column, do not place items here manually)
in Project Board
via automation
|
@SAUMILDHANKAR I'm not sure why github-actions didn't add labels but I'm going to go ahead and add them manually now so that people looking to review prs know the complexity and other information about this issue by looking at the labels |
JessicaLucindaCheng
added
Feature: Design system
Feature: Refactor CSS
@JessicaLucindaCheng Thanks for adding the labels. Looks like the workflow Set PR Labels did not get triggered for this PR. Will explore it further. |
@SAUMILDHANKAR I did not, the "fixes #xxxx" line should do that automatically, correct? I'm wondering if it has something to do with the commit from @1anya1 that's connected to this PR, I'm not sure how that's linked to this. I was reviewing her PR on a different branch but its showing up here for some reason. |
SAUMILDHANKAR
removed
the
Complexity: Small
github-actions
bot
added
the
Complexity: Small
|
Availability: 1 hour Edit: I'm a little confused by the comments here. I don't see the automated github-actions comment with the commands to review the pull request, either. @JessicaLucindaCheng and @SAUMILDHANKAR, is this safe to review? Updated review ETA: Friday, Mar 4, 2022 |
|
@tamara-snyder Good catch noticing there isn't the github-actions comment with the commands to review the pull request. You can still review it. I think there is just something wrong with the GitHub Actions automating the comment. See "Commandline instructions for Development Team" for instructions and the commands: https://github.com/hackforla/website/wiki/How-to-Review-Pull-Requests#step-3-view-the-changes-in-the-browser Also, I gave you access to a Google Sheet that you may need in order to review this pr. |
|
@JessicaLucindaCheng Thank you for clarifying and sharing the spreadsheet! |
5 tasks
tamara-snyder
approved these changes
Mar 7, 2022
There was a problem hiding this comment.
This looks good to me! The button's appearance is the same, I can see the new class in dev tools when I run the site locally, and clicking on the button opens up a new tab with the Wins form.
Also, thank you for updating the link as @JessicaLucindaCheng requested. I can see that it goes to the form that was already on the website and not to the outdated link. I'm sure it would be helpful if you could update the link on the CSS spreadsheet.
Thank you and great work on this issue!
Project Board
automation
moved this from PR Needs review (Automated Column, do not place items here manually)
to test-approved-by-reviewer (Automated Column, do not place items here manually)
Mar 7, 2022
|
Review ETA: End of day 3/7/22 |
ExperimentsInHonesty
removed this from test-approved-by-reviewer (Automated Column, do not place items here manually)
in Project Board
JessicaLucindaCheng
added a commit
to JessicaLucindaCheng/website
that referenced
this pull request
Apr 14, 2022
* Update how the overview link opens for Engage (hackforla#2734) Engage's overview link was updated so it opens the Engage-Product-One-Sheet.pdf in a new tab. * Update meeting data * Update contributor and language data * Update issue templates We updated the Project profile card template to include VRMS instructions for meeting time change * Update tech dropdown 2397 (hackforla#2672) * added css grid to technologies dropdown * added media queries for min-width 768 & min-width 1024 * removed redundant css from min-width 1024 * updated comments * removed comment out css * added variables $bp-tablet-up} & $bp-desktop-up * added scrollbar * updated height for desktop * changes to account for Surface Duo Screen 540px * added layout for ipad air with comments * changed $bp-ipadair-up to $bp-ipadair-up * Removed comments unrelated to pr 2672 from variables/_layout.scss (hackforla#2724) * Update meeting data * Update contributor and language data * Update communities-of-practice-information-updates.yml added a feature label to the template * Tooltip bug fix (hackforla#2713) * added overflow visible to project-card-wins-card style in winspage sccss. * Updated Git Wiki link in Contributing.md (hackforla#2741) * Update link in Contributing.md (hackforla#2742) * Update meeting data * Update contributor and language data * Apply Title heading class to Events page hackforla#2081 (hackforla#2645) * added Title class to specified event headings * added title-meetup text-color class to match figma * lowercased title classes * utilizing color-black and updated h5 to h4 * added text color property to day-header-1 * Update meeting data * Update contributor and language data * Revert "Removed comments unrelated to pr 2672 from variables/_layout.scss (hackforla#2724)" This reverts commit 3bc8d50. * Revert "Update tech dropdown 2397 (hackforla#2672)" This reverts commit 9b97a8b. * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * change b tag to strong tag (hackforla#2762) Co-authored-by: Jason Yee <jasonyee@jasons-air.lan> * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Updated pre-work developer template Added a checkbox for reading 2.6 What to do when you need to stop mid issue. (Section 2.6 is in the Contributing.md). * Added the template to edit content field and remove type field in a Credits file * Clarified wording in Credits file template: Edit content field and remove type field * removed about-us file (hackforla#2769) * Update meeting data * Update contributor and language data * Update Credits file template: Edit content field and remove type field Included this line in the template "This issue is tracked in the epic hackforla#2775." * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Update meeting data * Made changes to spare.md issue 2437 (hackforla#2778) * Update contributor and language data * Update link 100automations 2233 (hackforla#2785) * change url in md file * update url in md file * Add youth justice pdf and link it to overview (hackforla#2780) * access - update to strong (hackforla#2786) * Apply heading class to Program Areas Page (hackforla#2779) * applied heading class to Program Areas Page * changed h3 tag to h2 tag * Update meeting data * Update contributor and language data * pages/getting-started-with-video.html was removed from the fileand the error 404 page appeared when checking in localhost:4000 (hackforla#2788) * Updated Credits file template: Edit content field and remove type field * Update Credits file template: Edit content field and remove type field Clarified that the permalinks should be for the content and type fields * Update Credits file template: Edit content field and remove type field Clarified a sentence * Change bold to strong in step 5 (hackforla#2787) * Change bold to strong in step 5 * fixed indentation and spacing * Update meeting data * Update contributor and language data * Updated Credits file template: Edit content field and remove type field Clarified the title and a sentence in the template * Updated Alt Text Audit - Dev Fixed typo * Updated Credits file template: Edit content field and remove type field Added an example of a permalink as a comment on the bottom of the template. * Updated Alt Text Audit - Dev Add the 1pt size label to the template * Update meeting data * Update contributor and language data * Update issue templates updated the UX pre template * Update meeting data * Update contributor and language data * replaced hard coded blue colors with variables, removed unused blues (hackforla#2767) * applied title3 class to h2 tags (hackforla#2803) * add program-area text to Resources section (hackforla#2819) * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Refactor Buttons on Sitemap and Events Pages - hackforla#2159 (hackforla#2789) * Refactor buttons on line 43 of website/pages/sitemap.html, line 65 of website/pages/sitemap.html, and line 19 of website/_includes/events-page/left-col-content.html * Update made to change bold to strong for line 91 (hackforla#2841) * Update meeting data * Update contributor and language data * remove-non-existent-classes-2721 (hackforla#2879) * Update meeting data * Update contributor and language data * edited act.yml file (hackforla#2883) * clarified contributing section in README.md (hackforla#2881) * Update meeting data * Update contributor and language data * update program-area text (hackforla#2885) * made changes to CONTRIBUTING.md for easier understanding (hackforla#2893) * Added weekly meeting requirements * Update meeting data * Update contributor and language data * Edited meeting requirement note after feedback * Update meeting data * Update contributor and language data * Applied design system heading classes to Getting Started page (hackforla#2889) * Apply design system heading classes to Getting Started page * replaced p tag with h2 tag * adding blank issue form and renaming blank-issue- to blank-issue-template (hackforla#2899) * Update blank-issue-form.yml Removed blank title, labels, and assignees to fix the template so it shows up as an issue template option when creating a new issue. * removed the extra colons (hackforla#2903) * Update meeting data * Update contributor and language data * updated leadership in ops.yml (hackforla#2894) * move script to an external javascript file (hackforla#2882) * Update meeting data * Update contributor and language data * Update COP engineering section (hackforla#2905) * Remove Greg Pawin and add Avali to COP Engineering section * Change picture to github picture * Add paragraph classes 1-3 to codebase (hackforla#2880) * Added variables for the font sizes and line height for the paragraph classes * Added paragraph classes 1-3 %paragraph-class is a SCSS placeholder class, which has properties that are the same in all the paragraph classes. * Fixed typo * Updated Credits file template: Edit content field and remove type field Clarified the Overview section, added the Details section, and moved the "This issue is tracked in the epic hackforla#2775." to the Resources/Instructions section * Added the template: Project md file: Removing unused `alt-hero` field * Update meeting data * Update contributor and language data * Clarified meeting times in developer pre-work template * Added a colon back that was accidentally removed in developers pre-work issue * Updated column Updated column where issues need to be added if there are questions * Update meeting data * Update contributor and language data * Adding info on how to make a PR * Update meeting data * Update contributor and language data * Clarified a couple of sentences in the pre-work developers template * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Refactor of Wins Page Button (hackforla#2918) * refactor button per css standardization * revert forms link per request * Updated dev prework with issue progression with increasing complexity info * Update meeting data * Update contributor and language data * Added/modified pts label to some of the templates Added/modified pts label to the following templates: - Credits file template: Edit content field and remove type field - Pre-work Template - Developers - Project md file: Removing unused `alt-hero` field - Project Profile Card review and update * Edited wording in Project md file: Removing unused `alt-hero` field * Updated Credits file template: Edit content field and remove type field * Update meeting data * Update contributor and language data * Updated pre-work developer checklist * Update meeting data * Update contributor and language data * Update issue templates changes spacing * Update meeting data * Update contributor and language data * changed the overview link for the markdown file to show the pdf as em… (hackforla#2772) * changed the overview link for the markdown file to show the pdf as embedded * updating the tdm-calculater.md and pdf * add-priogrm-area-spare-2280 (hackforla#2957) * add-priogrm-area-spare-2280 * add-priogrm-area-spare-2280 * fixed mispelled word (hackforla#2966) * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * lowercase agile.yml file (hackforla#2971) * Sort events by project (hackforla#2963) * Refactor events page html script to js file (hackforla#2943) * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Removed alt hero from 100-automations.md 2891 (hackforla#2980) * Fix variable name in citizen-engagement.js (hackforla#2981) * removed card-body and card-width class (hackforla#2973) * removed card-body and card-width class Co-authored-by: scarter31191 <scarter31191@gmaile.com> * Update meeting data * Update contributor and language data * Fix alignment of news section on About page (hackforla#2969) * make changes reflective to Figma design for HfLA in the news * update the width property on news-cells * add new width property for desktop view on news-cells * resolved-issue-2896 (hackforla#2970) * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Hide all-time contributors 2605 (hackforla#2967) * Hide contributors div if number of all time contributors is less than number of people on the current project team * Add explanatory comment * Communities of practice info update 2758 (hackforla#2979) * modify project-management.yml to update project/product management leadership * book.yml: changed 'content' to 'content-type' and removed 'type' field (hackforla#2983) * Add program-area field to Green Earth OS (hackforla#2986) * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Removed Isaac from website project leadership section (hackforla#2992) * Update overview link 2238 (hackforla#2995) * add civic tech overview page to assets folder * change link in markdown file * update overview link in markdown * update link * revert * fix link * fix link * update links * update link * fixes link * update link * update link * fix link again * fix link again * Updated alt text to adhere to WCAG (hackforla#2982) * Update meeting data * Update contributor and language data * Update lucky parking project page (hackforla#2991) * update 311 info page 2987 (hackforla#2994) * Update meeting data * Update contributor and language data * Deleted unused alt-hero field in design-systems.md(hackforla#3000) * Update project team in guides-team.md (hackforla#2996) * remove Thuy Le, Carol Zhu, and affiliated links * CONTRIBUTING.md: stopping mid issue text update (hackforla#2998) * Modify line 461 CONTRIBUTING.md * Update meeting data * Update contributor and language data * fixed typo for issue hackforla#2911 (hackforla#3006) * Update meeting data * Update contributor and language data * Add issue progression to section 2.1 in CONTRIBUTING.md (hackforla#3007) * Update project info for Home Unite Us (hackforla#3001) * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Fix typo on Citizen Engagement page (hackforla#3013) * Updated Tools and Current Project Team sections for the Design Systems project profile (hackforla#3012) * removed tools and leadership members * added leadership members * removed unnecessary extra spaces * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Remove alt-hero tag from civic-tech-structure.md (hackforla#3017) * Add weekly time commitment requirements (hackforla#3015) * Corrected speeling of 'accommodate' in sitemap html file. (hackforla#3010) * Update meeting data * Update contributor and language data * Change text size for getting started page 2656 (hackforla#2988) * add-priogrm-area-spare-2280 * add-priogrm-area-spare-2280 * changing text size for Getting Started Page * change-text-size-for-getting-started-page-2656 * Update meeting data * Update contributor and language data * Applied "title3" Classes to Headings. (hackforla#3008) * added 'title3' class to headings, changed h3 tags to h2 for better semantics * changed src path for header-hero-image * Mobile_responsiveness Template to Github Form (hackforla#3014) * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Added program area 2384 (hackforla#2790) * Made changes to spare.md issue 2437 * added program area issue 2384 * Delete spare.md * Added program area 2384 * Added program area 2384 * Update jobs-for-hope.md * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Update issue templates Updated design template to contain a link to prioritized backlog design issues in the check box section * Changed label from good first issue to prework for pre-work checklists * Update meeting data * Update contributor and language data * Update food-oasis.md (hackforla#3033) * Update food-oasis.md * Add files via upload adding the pdf for food oasis * Update food-oasis.md * Added tools section to current project cards (hackforla#3020) * Added tools section to current project cards * Capitalize Tool to match surrounding fields * Update meeting data * Update contributor and language data * added NoSQL.svg to technologies-icons folder (hackforla#3030) * Added Section 3.1.b.v, How to add a pull request to the project board, to CONTRIBUTING.md (hackforla#3029) * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Added The School of law logo issue 3025 (hackforla#3037) * Update wins card format 2339 (hackforla#2977) * Fixed "See More" display on wins cards * Added query in js and functionally mobile "See More" buttons * Update meeting data * Update contributor and language data * Update Pre-work Template - Developers Clarified that the progress through issues by complexity is to be read and understood, and then can be checked off * Update meeting data * Update contributor and language data * Update design and research pre-work templates with a size label This is to prevent GHA writing a comment to new members about a missing size label and confusing them. * Added the time spent so far action item Added the time spent so far action item * Update meeting data * Update contributor and language data * Update meeting data * Update contributor and language data * Updated Community Survey Project .md to accurately display current Pr… (hackforla#3036) * Updated Community Survey Project .md to accurately display current Project Team leadership. * Added one current project team member to to the Open Community Survey Project card. * Added Open Survey Project pdf to website assets. added overview link to open-community-survey.md * Changed contributer title from 'project manager' to 'product manager. Corrected contributer's github handle. * Update meeting data * Update contributor and language data Co-authored-by: Brian Borin <brianborin@icloud.com> Co-authored-by: GitHub Actions Bot <hackforla-bot@hackforla.org> Co-authored-by: Providence-o <97491889+Providence-o@users.noreply.github.com> Co-authored-by: Anthony Sim <31682285+anthonysim@users.noreply.github.com> Co-authored-by: Bonnie Wolfe <37763229+ExperimentsInHonesty@users.noreply.github.com> Co-authored-by: Tomas Gonzalez <63771558+R-Tomas-Gonzalez@users.noreply.github.com> Co-authored-by: Frank Stepanski <fsjay@hotmail.com> Co-authored-by: Lindsey <89806097+lindseyindev@users.noreply.github.com> Co-authored-by: Jason Yee <42814942+JasonY188@users.noreply.github.com> Co-authored-by: Jason Yee <jasonyee@jasons-air.lan> Co-authored-by: Saumil Dhankar <saumil.dhankar@yahoo.com> Co-authored-by: Carlos <85038929+Carlos-A-P@users.noreply.github.com> Co-authored-by: KazushiR <38971729+KazushiR@users.noreply.github.com> Co-authored-by: luke-karis <69996875+luke-karis@users.noreply.github.com> Co-authored-by: Sparky-code <95888938+Sparky-code@users.noreply.github.com> Co-authored-by: Gabriel Garcia <78570619+Gorck1416@users.noreply.github.com> Co-authored-by: Adolf Schmuck <britvaica@netscape.net> Co-authored-by: Tamara Snyder <57715733+tamara-snyder@users.noreply.github.com> Co-authored-by: Anna Filatova <52765927+1anya1@users.noreply.github.com> Co-authored-by: Ahmad Tahir <30394037+A-BMT02@users.noreply.github.com> Co-authored-by: harshitasao <84518563+harshitasao@users.noreply.github.com> Co-authored-by: jnmrles <36289969+jnmrles@users.noreply.github.com> Co-authored-by: Utkarsh Saboo <44554270+usaboo@users.noreply.github.com> Co-authored-by: Sarah Sanger <blulady@gmail.com> Co-authored-by: Jaretzbalba <93153059+Jaretzbalba@users.noreply.github.com> Co-authored-by: Ben Montgomery <98272636+Benji-Montgomery@users.noreply.github.com> Co-authored-by: Steve Carter <66285451+scarter31191@users.noreply.github.com> Co-authored-by: scarter31191 <scarter31191@gmaile.com> Co-authored-by: Poorvi Rao <41170744+poorvi4@users.noreply.github.com> Co-authored-by: riddle015 <hiramriddle@gmail.com> Co-authored-by: Matthew Cacho <48004150+macho-catt@users.noreply.github.com> Co-authored-by: RyanCahela <6194542+RyanCahela@users.noreply.github.com> Co-authored-by: kathrynsilvaconway <81049661+kathrynsilvaconway@users.noreply.github.com>
tunglinn
added
Complexity: Small
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2187
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
** No visible changes, code refactoring