Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken image in CONTRIBUTING.md #6690

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

moazDev1
Copy link
Member

@moazDev1 moazDev1 commented Apr 20, 2024

Fixes #6582

What changes did you make?

  • Fix broken image in CONTRIBUTING.md file under section 2.7.d

Why did you make the changes (we will use this info to test)?

  • Enhance readability and accuracy for the documentation

For Reviewers: Do not review changes locally, rather, review changes at https://github.com/moaz-dev1/website/blob/gh-pages/CONTRIBUTING.md

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@HackforLABot HackforLABot added this to PR Needs review (Automated Column, do not place items here manually) in Project Board Apr 20, 2024
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b moaz-dev1-fix-broken-image-6582 gh-pages
git pull https://github.com/moaz-dev1/website.git fix-broken-image-6582

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/moaz-dev1/website/blob/fix-broken-image-6582/CONTRIBUTING.md  

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Wiki Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Apr 20, 2024
@moazDev1 moazDev1 changed the title Fix broken image (#6582) Fix broken image in CONTRIBUTING.md Apr 21, 2024
Project Board automation moved this from PR Needs review (Automated Column, do not place items here manually) to test-approved-by-reviewer (Automated Column, do not place items here manually) Apr 21, 2024
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @moaz-dev1 on this PR. You setup the branches correctly, described your work, made the change correctly and cleanly, and provided a link for reviewers to view the formatted document. Thank you !

@Thinking-Panda
Copy link
Member

@duojet2ez - Please post your availability and ETA to review this PR. Thanks!

@Jperparas
Copy link
Member

ETA: EoD 4/25
Availability: 4/24-4/25 early afternoon

@duojet2ez
Copy link
Member

@Thinking-Panda do we normally have multiple ppl reviewing pull requests? I need to review the documentation on PR

I can work on this 4/25 and 4/26 throughout the day both days

@moazDev1
Copy link
Member Author

Hey @duojet2ez thanks for reaching out
Yes, many people can review the PR, It requires at least 2 approved reviews for the PR to be merged but could be more

Copy link
Member

@Jperparas Jperparas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job on this issue!
branch labeled correctly and merging into correct branch, issue linked, visual changes documented, review link provided.

Keep up the good work!

@jphamtv jphamtv merged commit 01fdbee into hackforla:gh-pages Apr 25, 2024
14 checks passed
@HackforLABot HackforLABot removed this from test-approved-by-reviewer (Automated Column, do not place items here manually) in Project Board Apr 25, 2024
@moazDev1 moazDev1 deleted the fix-broken-image-6582 branch April 25, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Wiki role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken image in CONTRIBUTING.md Section 2.7.d
6 participants