-
-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken image in CONTRIBUTING.md
#6690
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
CONTRIBUTING.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @moaz-dev1 on this PR. You setup the branches correctly, described your work, made the change correctly and cleanly, and provided a link for reviewers to view the formatted document. Thank you !
@duojet2ez - Please post your availability and ETA to review this PR. Thanks! |
ETA: EoD 4/25 |
@Thinking-Panda do we normally have multiple ppl reviewing pull requests? I need to review the documentation on PR I can work on this 4/25 and 4/26 throughout the day both days |
Hey @duojet2ez thanks for reaching out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job on this issue!
branch labeled correctly and merging into correct branch, issue linked, visual changes documented, review link provided.
Keep up the good work!
Fixes #6582
What changes did you make?
CONTRIBUTING.md
file under section 2.7.dWhy did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied