Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Projects and homepages 4593 #6747

Open
wants to merge 18 commits into
base: gh-pages
Choose a base branch
from
Open

Projects and homepages 4593 #6747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
617682c
modified styling for filter, searchbar, and projects list to improve …
Anahisv23 Apr 24, 2024
3d6f9a5
Merge branch 'gh-pages' of https://github.com/hackforla/website into …
Anahisv23 Apr 24, 2024
fbc6e30
addressed concerns on this issue
Anahisv23 May 21, 2024
b574c6a
Update _dropdown_filters.scss line 19
Anahisv23 May 21, 2024
38c9e85
Update _main.scss by removing height styling
Anahisv23 May 21, 2024
2bc859a
Refactored css based on additional feedback on filter and project lis…
Anahisv23 Jun 1, 2024
283f0ea
Merge branch 'gh-pages' of https://github.com/hackforla/website into …
Anahisv23 Jun 1, 2024
404889d
Merge branch 'gh-pages' of https://github.com/hackforla/website into …
Anahisv23 Jun 4, 2024
9202f22
Merge branch 'projects-and-homepages-4593' of github.com:Anahisv23/we…
Anahisv23 Jun 4, 2024
f11d2df
pinned search bar on mobile
Anahisv23 Jun 12, 2024
13cf0e2
updated styling on search bar to prevent it from pinning on mobile
Anahisv23 Jun 19, 2024
41fda13
updated filtersDiv, removed gap in between projects list and filters,…
Anahisv23 Jun 23, 2024
d3aa045
Merge branch 'gh-pages' of https://github.com/hackforla/website into …
Anahisv23 Jun 23, 2024
b7883cc
removed food-oasis.md file from commit
Anahisv23 Jun 28, 2024
8115c75
Merge branch 'gh-pages' of https://github.com/hackforla/website into …
Anahisv23 Jun 28, 2024
f7959c3
modified max height on dropdown show all css rule to fix scroll incon…
Anahisv23 Jun 28, 2024
795e081
addressing scrolling inconsistencies
Anahisv23 Jul 11, 2024
6af2c9c
Merge branch 'gh-pages' of https://github.com/hackforla/website into …
Anahisv23 Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
138 changes: 0 additions & 138 deletions _projects/food-oasis.md
View file
Open in desktop

This file was deleted.

24 changes: 21 additions & 3 deletions _sass/elements/_dropdown_filters.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@
// Centered Components and filters up top
section.filter-content-container {
display: flex;
justify-content: center;
justify-content: center;
}

.page-contain.projects-inner {
margin: 0px 0px;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.page-contain.projects-inner {
margin: 0; /* Use shorthand for consistency */
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mSharifHub thanks for the feedback! I think this change isn't within the scope of the issue so I'll go ahead and leave this as is. I did however go ahead and add the overflow-y: auto where you suggested. Thanks!

Expand All @@ -31,11 +32,18 @@ a.filter-item {
.filter-toolbar {
padding: 8px 32px;
box-sizing: border-box;
height: 100%;
height: calc(100vh - 60px);
position: sticky;
flex-shrink: 0;
top: 64px;
bottom: 0;
overflow-y: auto;
overflow-x: hidden;
}

.filtersDiv {
min-width:330px;
padding-bottom: 300px;
}

//filter container
Expand Down Expand Up @@ -115,10 +123,12 @@ ul.filter-list li ul li {
.dropdown.show-all li.view-all:last-child {
display: none;
}

.dropdown.show-all {
max-height: 360px;
overflow-y: scroll;
}

.dropdown.show-all li:nth-child(n+9) {
display: block;
}
Expand Down Expand Up @@ -244,10 +254,19 @@ a.clear-filter-tags {
.scroll-lock {
overflow: hidden;
}

.filter-toolbar {
background-color: $color-pink;
height: 100%;
position: static;
padding: 0;
}

.filtersDiv {
padding-bottom: 0px;
padding-top: 0px;
}

.filter-toolbar.show-filters {
height: 100vh;
width: 100vw;
Expand Down Expand Up @@ -343,5 +362,4 @@ a.clear-filter-tags {
.show-none + .dropdown li {
display: block;
}

}
12 changes: 12 additions & 0 deletions _sass/elements/_search-bar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,18 @@
margin-bottom: 10px;
}

form#search-bar {
position: sticky;
padding: 10px;
top: 60px;
z-index: 10;
}
// // Ensure search-bar does not pin on mobile
@media #{$bp-below-tablet} {
form#search-bar {
position: static;
}
}
//Styles to override the styles from _forms.scss
#search{
padding-right: 0px;
Expand Down
2 changes: 1 addition & 1 deletion _sass/layouts/_main.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,4 @@
// This is to provide padding for readability to the content in the default-markdown.html layout
#content-markdown {
padding: 200px 100px 300px 100px;
}
}