Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project profile in projects/civic-tech-jobs.md #6774

Merged
merged 7 commits into from
May 1, 2024

Conversation

moazDev1
Copy link
Member

@moazDev1 moazDev1 commented Apr 28, 2024

Fixes #6640

What changes did you make?

  • Update _projects/civic-tech-jobs.md file
  • Under leadership variable I did the following:
    • Remove Gabriel Vicencio & Nga Do
    • Add Brenda Njemanze & Manju Chawla

Why did you make the changes (we will use this info to test)?

  • Keep project information up to date so that visitors to the website can find accurate information.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

after

Changes are made under https://www.hackforla.org/projects/civic-tech-jobs

@HackforLABot HackforLABot added this to PR Needs review (Automated Column, do not place items here manually) in Project Board Apr 28, 2024
@moazDev1 moazDev1 changed the title Update project profile in 6640 projects/civic-tech-jobs.md Update project profile in projects/civic-tech-jobs.md #6640 Apr 28, 2024
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b moaz-dev1-update-project-profile-6640 gh-pages
git pull https://github.com/moaz-dev1/website.git update-project-profile-6640

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/moaz-dev1/website/blob/update-project-profile-6640/CONTRIBUTING.md  

@moazDev1 moazDev1 changed the title Update project profile in projects/civic-tech-jobs.md #6640 Update project profile in projects/civic-tech-jobs.md Apr 28, 2024
@github-actions github-actions bot added role: front end Tasks for front end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 28, 2024
@Anahisv23 Anahisv23 self-requested a review April 28, 2024 18:28
@Anahisv23
Copy link
Member

ETA: Monday April 29 11am - 5pm

@ajb176 ajb176 self-requested a review April 29, 2024 17:21
Copy link
Member

@ajb176 ajb176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @moaz-dev1, nice work on the issue. You haven't done much wrong but I'm going to request a slight change.

This is a little bit confusing because the previous version of the page didn't seem to be formatted correctly, but I believe the profiles are meant to be grouped together based on their roles. All members with the same role are meant to be adjacent with each other (i.e. all UX Designers, then all UX researchers, then all Developers).

Specifically:

  • Brenda's block should be right after Lu Feng's block where Gabriel used to be
  • Manju's block should be right after Leah Ellis'

In the previous version Nga Do's block was at the end which seems to have been a mistake.

Project Board automation moved this from PR Needs review (Automated Column, do not place items here manually) to test-pending-approval (Automated Column, do not place items here manually) Apr 29, 2024
Copy link
Member

@Anahisv23 Anahisv23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @moaz-dev1 nice work on this issue! Below I added what you did well on this issue. I agree with @ajb176, in order to ensure consistency with role titles you should reposition Brenda and Manju’s information to be where Gabriel and Ngo’s information was previously. 



Here’s what you did well:

  • There is a linked issue
  • Modified correct files
  • Removed Gabriel’s information
  • Removed Ngo ’s information
  • UI displays Brenda and Manju’s information on civic tech jobs project page

@moazDev1
Copy link
Member Author

Hey @ajb176 @Anahisv23, thanks for correcting me.
I just updated them, here is how it looks now

Before

image

After

image

Copy link
Member

@ajb176 ajb176 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice work @moaz-dev1

Copy link
Member

@Anahisv23 Anahisv23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @moaz-dev1

Project Board automation moved this from test-pending-approval (Automated Column, do not place items here manually) to test-approved-by-reviewer (Automated Column, do not place items here manually) Apr 30, 2024
@LRenDO
Copy link
Member

LRenDO commented May 1, 2024

Hi @moaz-dev1! Nice work on this PR and the updates. I am going to go ahead and merge, but when you have a moment can you please copy the most recent visual changes you posted in this comment into the original PR comment "Visuals after changes are applied" section. Just makes things a little easier to track if for some reason we needed to go back to this PR.

Again, nice work and thanks for taking on this issue!

@LRenDO LRenDO merged commit 3cb1010 into hackforla:gh-pages May 1, 2024
3 checks passed
@HackforLABot HackforLABot removed this from test-approved-by-reviewer (Automated Column, do not place items here manually) in Project Board May 1, 2024
jono4727 pushed a commit to jono4727/website that referenced this pull request May 1, 2024
@moazDev1 moazDev1 deleted the update-project-profile-6640 branch May 2, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Civic Tech Jobs (Remove Gabriel Vicencio & Nga Do; Add Brenda Njemanze & Manju Chawla)
4 participants