-
-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update project profile in projects/civic-tech-jobs.md
#6774
Update project profile in projects/civic-tech-jobs.md
#6774
Conversation
…fix-broken-image-6582
Fix broken image 6582
projects/civic-tech-jobs.md
projects/civic-tech-jobs.md
#6640
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
projects/civic-tech-jobs.md
#6640projects/civic-tech-jobs.md
ETA: Monday April 29 11am - 5pm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @moaz-dev1, nice work on the issue. You haven't done much wrong but I'm going to request a slight change.
This is a little bit confusing because the previous version of the page didn't seem to be formatted correctly, but I believe the profiles are meant to be grouped together based on their roles. All members with the same role are meant to be adjacent with each other (i.e. all UX Designers, then all UX researchers, then all Developers).
Specifically:
- Brenda's block should be right after Lu Feng's block where Gabriel used to be
- Manju's block should be right after Leah Ellis'
In the previous version Nga Do's block was at the end which seems to have been a mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @moaz-dev1 nice work on this issue! Below I added what you did well on this issue. I agree with @ajb176, in order to ensure consistency with role titles you should reposition Brenda and Manju’s information to be where Gabriel and Ngo’s information was previously.
Here’s what you did well:
- There is a linked issue
- Modified correct files
- Removed Gabriel’s information
- Removed Ngo ’s information
- UI displays Brenda and Manju’s information on civic tech jobs project page
Hey @ajb176 @Anahisv23, thanks for correcting me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, nice work @moaz-dev1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! @moaz-dev1
Hi @moaz-dev1! Nice work on this PR and the updates. I am going to go ahead and merge, but when you have a moment can you please copy the most recent visual changes you posted in this comment into the original PR comment "Visuals after changes are applied" section. Just makes things a little easier to track if for some reason we needed to go back to this PR. Again, nice work and thanks for taking on this issue! |
Fixes #6640
What changes did you make?
_projects/civic-tech-jobs.md
fileleadership
variable I did the following:Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied