Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update inactive members #6888

Merged
merged 7 commits into from
May 23, 2024
Merged

Update inactive members #6888

merged 7 commits into from
May 23, 2024

Conversation

moazDev1
Copy link
Member

Fixes #6837

What changes did you make?

Why did you make the changes (we will use this info to test)?

  • Due to an issue with the automation process, inactive-members.json wasn't updated automatically and required manual update.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes

@HackforLABot HackforLABot added this to PR Needs review (Automated Column, do not place items here manually) in Project Board May 23, 2024
@github-actions GitHub Actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b moazDev1-update-inactive-members-6837 gh-pages
git pull https://github.com/moazDev1/website.git update-inactive-members-6837

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers time sensitive Needs to be worked on by a particular timeframe Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 0.5pt Can be done in 3 hours or less labels May 23, 2024
@del9ra del9ra self-assigned this May 23, 2024
@patelbansi3009 patelbansi3009 self-requested a review May 23, 2024 19:08
@patelbansi3009
Copy link
Member

Review ETA: 9 PM 05/23/24
Availability: 3-9 PM Thursday (EST)

@del9ra
Copy link
Member

del9ra commented May 23, 2024

Review ETA: 10 PM May 23
Availability: 5-6 PM May 24

@patelbansi3009
Copy link
Member

Great job @moazDev1!

  • Used the correct branch for the pull request
  • Linked the issue correctly
  • Replaced the content of the file exactly mentioned in the issue
  • Made no visual changes on the website

patelbansi3009
patelbansi3009 approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@patelbansi3009 patelbansi3009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job @moazDev1!
Changes are made exactly per the issue. Thank you for contributing. Keep up the good work!!

Project Board automation moved this from PR Needs review (Automated Column, do not place items here manually) to test-approved-by-reviewer (Automated Column, do not place items here manually) May 23, 2024
del9ra
del9ra approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@del9ra del9ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @moazDev1, Nice job!

  • The branches are all set.
  • The issue is linked up.
  • Nice job on the brief explanation of the changes.
  • No visual changes on the website.
    Thanks for making these updates!

@jphamtv jphamtv merged commit 37f142f into hackforla:gh-pages May 23, 2024
10 checks passed
@HackforLABot HackforLABot removed this from test-approved-by-reviewer (Automated Column, do not place items here manually) in Project Board May 23, 2024
@moazDev1 moazDev1 deleted the update-inactive-members-6837 branch May 25, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patelbansi3009 patelbansi3009 patelbansi3009 approved these changes

@del9ra del9ra del9ra approved these changes

Assignees

@del9ra del9ra

Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 0.5pt Can be done in 3 hours or less time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update data in inactive-members.json file
4 participants
@moazDev1 @patelbansi3009 @del9ra @jphamtv