Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github handle field #7057

Closed
wants to merge 1 commit into from

Conversation

jazxbx
Copy link
Member

@jazxbx jazxbx commented Jun 24, 2024

Fixes #7050

What changes did you make?

-Add github-handle: on heart.md file

Why did you make the changes (we will use this info to test)?

--This variable will eventually replace github and picture variables to reduce redundancy in the project file.

No visual changes to the website.

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b jazxbx-add-github-handle-7050 gh-pages
git pull https://github.com/jazxbx/website.git add-github-handle-7050

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jun 24, 2024
@andyphancode andyphancode self-requested a review June 25, 2024 22:48
@andyphancode
Copy link
Member

Availability: Throughout week
ETA: 6/25 EOD

Copy link
Member

@andyphancode andyphancode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Changes in code appear correct
  • Branching is correct
  • PR summary contains necessary info

Everything looks good! Just wanted to ask for a more specific title for the Pull Request just for more organized book keeping. Maybe something like "Added github-handle to Tien Yuan section".

@roslynwythe roslynwythe requested a review from mrodz June 26, 2024 02:23
@mrodz
Copy link
Contributor

mrodz commented Jun 26, 2024

Availability: every day 9AM-8PM
ETA: 6/25 7:45

Copy link
Contributor

@mrodz mrodz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

  • Good source branch and destination branch
  • Linked issue number
  • No visual changes
  • The new YAML property uses a delimiter of whitespaces

I concord with @andyphancode that the name of the PR should include at least Tien Yuan's name. Once you rename the PR, make sure to re-request our reviews so that we can get your work merged!

Thanks for your time :)

@LRenDO
Copy link
Member

LRenDO commented Jun 26, 2024

Closing this as there were two issues for this change #7050 and #6941 and the PR for #6941 was just merged ( #7069 ). @jazxbx, apologies for the duplication of work. Please feel free to grab another first good issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add github-handle for Tien Yuan in heart.md
4 participants