Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes are not taken when putting a "/" character in the filename #275

Closed
romainnorberg opened this issue Mar 20, 2018 · 4 comments
Closed

Comments

@romainnorberg
Copy link

Environment info

  • OS: MacOs Sierra 10.12.6 (16G1212)
  • App Version (Command/Ctrl + ,): v1.6.0

Description of the problem / feature request / question:

Changes are not taken when putting a "/" character in the filename (see gif), no error message is provided.
Github doesn't allow /' in the name

If possible, provide a sample gist or screenshot:

recordIt

@hackjutsu
Copy link
Owner

It's not a valid token for a filename in most OSs, maybe we need a warning for that. To be honest, I don't know why users would try this...

@romainnorberg
Copy link
Author

users often do mistake like this

@hackjutsu
Copy link
Owner

FYI, cmd + e is the shortcut for editing an existing gist.

@hackjutsu
Copy link
Owner

hackjutsu commented Mar 21, 2018

Duplicate issue: #268
Reference package: https://www.npmjs.com/package/valid-filename
Relevant code: https://github.com/hackjutsu/Lepton/blob/master/app/containers/gistEditorForm/index.js#L68

This seems to be a simple fix and a low hanging PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants