Test testy: Bump specs version and fix specs for current API. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specs were a bit outdated, shame on me, but now reflect the current API. No specs yet for withFields or field groups.
We actually now pull this from Lift's implementation, which I fixed when I actually wrote tests for the thing... When we bump lift-formality to depend on Lift 3, we'll be able to lean directly on Lift's implementation of HLists anyway.
These are now SScope and IntFieldScope, keeping with specs2 terminology, and properly wrap each of the specs that use them individually to provide isolation (though we could use `isolated` for that as well). All tests pass now, boom!
|
Green light from travis == merging this suckah. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specs were a bit outdated, shame on me, but now reflect the current API.
No specs yet for withFields.
Even got travis set up here…