fix uploads

hackmdio · Apr 30, 2024 · 2921fc0 · 2921fc0
1 parent d74e201
commit 2921fc0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/app.js b/app.js
@@ -227,7 +227,7 @@ app.locals.enableGitHubGist = config.isGitHubEnable
 app.locals.enableGitlabSnippets = config.isGitlabSnippetsEnable
 
 app.use('/uploads', (req, res, next) => {
-  if (req.session.user) next()
+  if (req.isAuthenticated()) next()
   else response.errorNotFound(req, res)
 }, express.static(path.resolve(__dirname, config.uploadsPath), { maxAge: config.staticCacheTime }))
 

diff --git a/deployments/Dockerfile b/deployments/Dockerfile
@@ -23,6 +23,7 @@ USER hackmd
 ENV QT_QPA_PLATFORM=offscreen
 WORKDIR /home/hackmd/app
 COPY --chown=1500:1500 --from=BUILD /home/hackmd/app .
+RUN mkdir /tmp/uploads
 RUN npm install --production && npm cache clean --force && rm -rf /tmp/{core-js-banners,phantomjs}
 EXPOSE 3000
 ENTRYPOINT ["/home/hackmd/app/docker-entrypoint.sh"]
diff --git a/lib/config/default.js b/lib/config/default.js
@@ -48,7 +48,7 @@ module.exports = {
   tmpPath: os.tmpdir(),
   defaultNotePath: './public/default.md',
   docsPath: './public/docs',
-  uploadsPath: './public/uploads',
+  uploadsPath: '/tmp/uploads',
   // session
   sessionName: 'connect.sid',
   sessionSecret: 'secret',