Skip to content

Commit

Permalink
lint: lib/realtime/realtime.ts
Browse files Browse the repository at this point in the history
- add socker.request

Signed-off-by: Raccoon <raccoon@hackmd.io>
  • Loading branch information
a60814billy committed Jun 14, 2021
1 parent 50e8286 commit 913f9af
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
3 changes: 2 additions & 1 deletion lib/realtime/realtime.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import {CursorData, RealtimeClientConnection} from "./realtimeClientConnection";
import {UpdateDirtyNoteJob} from "./realtimeUpdateDirtyNoteJob";
import {CleanDanglingUserJob} from "./realtimeCleanDanglingUserJob";
import {SaveRevisionJob} from "./realtimeSaveRevisionJob";
import SocketRequest = SocketIO.SocketRequest;


export interface RealtimeUserData {
Expand Down Expand Up @@ -497,7 +498,7 @@ export function emitRefresh(socket: SocketIO.Socket): void {
socket.emit('refresh', out)
}

export function checkViewPermission(req, note: RealtimeNoteData): boolean {
export function checkViewPermission(req: SocketRequest, note: RealtimeNoteData): boolean {
if (note.permission === 'private') {
if (req.user && req.user.logged_in && req.user.id === note.owner) {
return true
Expand Down
8 changes: 8 additions & 0 deletions typings/socket.io/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,17 @@ declare namespace SocketIO {
} | any
}

export interface SocketRequest {
user?: {
logged_in: boolean
id: string
}
}

export interface Socket {
origin?: any
noteId?: string
request: SocketRequest | any
}

}

0 comments on commit 913f9af

Please sign in to comment.