Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSTS⇒maxAge in config must not be a string #1159

Closed
Nebukadneza opened this issue Mar 4, 2019 · 0 comments
Closed

HSTS⇒maxAge in config must not be a string #1159

Nebukadneza opened this issue Mar 4, 2019 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@Nebukadneza
Copy link

Hi,

with the recent docker image update, the docker fails to start with the sample config, and i guess many user configs too, with:

app_1_c5e3955ff34f | 2019-03-04T12:22:45.572362083Z 2019-03-04T12:22:45.571Z error: 	uncaughtException: HSTS must be passed a numeric maxAge parameter.
app_1_c5e3955ff34f | 2019-03-04T12:22:45.572386521Z TypeError: HSTS must be passed a numeric maxAge parameter.
app_1_c5e3955ff34f | 2019-03-04T12:22:45.572391266Z     at Function.hsts (/codimd/node_modules/hsts/index.js:17:11)
app_1_c5e3955ff34f | 2019-03-04T12:22:45.572394590Z     at Object.<anonymous> (/codimd/app.js:85:18)
app_1_c5e3955ff34f | 2019-03-04T12:22:45.572397977Z     at Module._compile (module.js:653:30)
app_1_c5e3955ff34f | 2019-03-04T12:22:45.572400989Z     at Object.Module._extensions..js (module.js:664:10)
app_1_c5e3955ff34f | 2019-03-04T12:22:45.572403913Z     at Module.load (module.js:566:32)
app_1_c5e3955ff34f | 2019-03-04T12:22:45.572406751Z     at tryModuleLoad (module.js:506:12)
app_1_c5e3955ff34f | 2019-03-04T12:22:45.572409738Z     at Function.Module._load (module.js:498:3)
app_1_c5e3955ff34f | 2019-03-04T12:22:45.572412867Z     at Function.Module.runMain (module.js:694:10)
app_1_c5e3955ff34f | 2019-03-04T12:22:45.572415813Z     at startup (bootstrap_node.js:204:16)
app_1_c5e3955ff34f | 2019-03-04T12:22:45.572418859Z     at bootstrap_node.js:625:3

Fix is easy: remove the " around the maxAge parameter in the config. It would be great if at least the sample config adapted to the hsts module handling of the config-value …

As always, thanks for the great project ^_^

@SISheogorath SISheogorath added the bug Something isn't working label Mar 4, 2019
@SISheogorath SISheogorath added this to the 1.3.1 release milestone Mar 4, 2019
pandy1988 pushed a commit to pandy1988/codimd that referenced this issue Sep 13, 2019
HSTS maxAge has to be an integer, not a string.

Fixes hackmdio#1159

Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
edgarogh pushed a commit to WartaPoirier-corp/codimd that referenced this issue Sep 21, 2021
…ader-5.x

Update dependency css-loader to v5.2.4 (master)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants