You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The easiest migration path for users of this module is to provide userProfileURL: https://www.googleapis.com/oauth2/v3/userinfo, in the strategy options
Like so:
newGoogleStrategy({clientID: GOOGLE_CLIENT_ID,clientSecret: GOOGLE_CLIENT_SECRET,callbackURL: "http://www.example.com/auth/google/callback",// This option tells the strategy to use the userinfo endpoint insteaduserProfileURL: "https://www.googleapis.com/oauth2/v3/userinfo",}
Since Google+ is shutting down soon, we need to get the profile data
from another URL. Since the library already supports it, all we need to
do is adding a single line of code.
Details:
hackmdio#1160
Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
edgarogh
pushed a commit
to WartaPoirier-corp/codimd
that referenced
this issue
Sep 21, 2021
I don't know if you've heard but Google is closing it's Google+ legacy API:
https://developers.google.com/+/api-shutdown
https://developers.google.com/+/scopes-shutdown
I found that you are using passport-google-oauth2 for Google OAuth:
codimd/lib/web/auth/google/index.js
Line 5 in e48342a
And there is an issue in their repo related to this:
jaredhanson/passport-google-oauth2#50
And this specific comment explains that it already supports it:
jaredhanson/passport-google-oauth2#50 (comment)
Which is handled by this PR:
jaredhanson/passport-google-oauth2#51
And states:
Like so:
I can see this has not been done in your module:
codimd/lib/web/auth/google/index.js
Lines 11 to 15 in e48342a
My question is: Does CodiMD require this change to continue to have Google OAuth work correctly?
The text was updated successfully, but these errors were encountered: