Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using emoji breaks HTML export #1164

Closed
dhavlik opened this issue Mar 8, 2019 · 1 comment
Closed

Using emoji breaks HTML export #1164

dhavlik opened this issue Mar 8, 2019 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@dhavlik
Copy link

dhavlik commented Mar 8, 2019

In our instance running 1.3.0, after adding an emoji to the content of a pad, HTML export is no longer working:

TypeError: r is undefined

The error is triggered by this code:

  src.find('img.emoji').each((key, value) => {
    let name = $(value).attr('alt')

Looking at the DOM, it seems emojis do not get an alt-attribute. After adding it in inspector, the HTML export works.

Seems like the issue here is that the emojis don't get the alt-attr. I tried to find out where emojis are added, but couldn't locate the piece of code.

@ccoenen
Copy link
Contributor

ccoenen commented Mar 8, 2019

I can confirm this issue on our demo instance. This document here can't be exported via menu -> HTML.

https://demo.codimd.org/LYPSOcwpQqGS7F120FuJHA#

Personally, I dislike the way it's handled: after downloading the document it's then dependent on some odd CDN being available for all time. Maybe we can fix this at the same time.

@SISheogorath SISheogorath added the bug Something isn't working label Mar 9, 2019
@SISheogorath SISheogorath added this to the 1.3.1 release milestone Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants