Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide default ports from minio image upload urls #1095

Merged
merged 2 commits into from Apr 15, 2019

Conversation

Thor77
Copy link
Contributor

@Thor77 Thor77 commented Dec 11, 2018

With the current state this behaviour is enabled by default and can be disabled by setting

{
  "minio": {
    "hideDefaultPorts": false
  }
}

or CMD_MINIO_HIDE_DEFAULT_PORTS=false.

Fix #1094

Signed-off-by: Thor77 <thor77@thor77.org>
@SISheogorath
Copy link
Contributor

I think we can omit the config setting in favour of just removing the port when it's 443 or 80. I don't expect people to run HTTP on 443 and HTTPS on port 80. If they do, we'll tell them that it's not supported.

@Thor77
Copy link
Contributor Author

Thor77 commented Dec 12, 2018

Alright, removed the commits. Will remove the checks for the protocol as well.
Should I document this somewhere/how else then?

@SISheogorath SISheogorath added the enhancement Wants to improvide an existing feature label Dec 12, 2018
@SISheogorath SISheogorath added this to the 1.4.0 Release milestone Dec 12, 2018
Signed-off-by: Thor77 <thor77@thor77.org>
@Thor77
Copy link
Contributor Author

Thor77 commented Dec 12, 2018

Replaced the protocol + port check with one for port being 80 or 443.

@a60814billy
Copy link
Member

Thanks @Thor77

@a60814billy a60814billy changed the base branch from master to develop April 15, 2019 05:48
@a60814billy a60814billy merged commit 48a68e0 into hackmdio:develop Apr 15, 2019
@Thor77 Thor77 deleted the fix-1094 branch April 15, 2019 07:07
pandy1988 pushed a commit to pandy1988/codimd that referenced this pull request Sep 13, 2019
Hide default ports from minio image upload urls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Wants to improvide an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants