Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix urlpath in webpack build #1378

Merged
merged 1 commit into from Dec 13, 2019
Merged

Fix urlpath in webpack build #1378

merged 1 commit into from Dec 13, 2019

Conversation

Yukaii
Copy link
Member

@Yukaii Yukaii commented Dec 13, 2019

fixes #1358

@Yukaii Yukaii added this to the 1.4.1 milestone Dec 13, 2019
@Yukaii Yukaii self-assigned this Dec 13, 2019
@Yukaii Yukaii temporarily deployed to codimd-bugfix-urlpath-k3ds2r0k December 13, 2019 09:06 Inactive
@Yukaii
Fix urlpath in webpack build
a1c5c68 
Signed-off-by: Yukai Huang <yukaihuangtw@gmail.com>
@Yukaii Yukaii temporarily deployed to codimd-bugfix-urlpath-k3ds2r0k December 13, 2019 09:06 Inactive
@jackycute
Copy link
Member

Thanks, LGTM @Yukaii

@jackycute jackycute merged commit b634ee2 into develop Dec 13, 2019
@jackycute jackycute deleted the bugfix/urlpath branch December 13, 2019 09:24
Yukaii added a commit that referenced this pull request Jul 6, 2020
@Yukaii
Fix baseUrl not replaced correctly in #1378
c677938 
Signed-off-by: Yukai Huang <yukaihuangtw@gmail.com>
Yukaii added a commit that referenced this pull request Jul 10, 2020
@Yukaii
Fix baseUrl not replaced correctly in #1378
70de439 
Signed-off-by: Yukai Huang <yukaihuangtw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackycute jackycute jackycute approved these changes

Assignees

@Yukaii Yukaii

Labels
None yet
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.

urlpath config is broken
2 participants
@Yukaii @jackycute