Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade "pg" to 8.0 so sequelize does not fail to connect to postgres on node14 #1712

Closed
wants to merge 4 commits into from

Conversation

byondrealdev
Copy link

@jackycute jackycute requested review from Yukaii and a60814billy and removed request for Yukaii October 10, 2021 04:24
@jackycute
Copy link
Member

Hi @byondrealdev,

Thanks for the PR.
However, I'm wondering why there are two unrelated file changes: locales/en.json and locales/zh-CN.json, could you revert those modifications?

Also, could you sign the commit? https://github.com/hackmdio/codimd/blob/develop/CONTRIBUTING.md#sign-your-work

@jackycute
Copy link
Member

This might fix by #1784

@Yukaii
Copy link
Member

Yukaii commented Jan 2, 2024

Close since #1784 is merged.

@Yukaii Yukaii closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants