Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the logout callback to prevent exception. #1813

Closed
wants to merge 1 commit into from

Conversation

hcyuser
Copy link
Contributor

@hcyuser hcyuser commented Aug 9, 2023

No description provided.

Copy link
Contributor Author

@hcyuser hcyuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add callback for logout

Signed-off-by: hcyuser <user@hcy.idv.tw>
@jackycute
Copy link
Member

Hi @hcyuser,

Thanks for contribution.
Can you explain what is this PR solving?

@hcyuser
Copy link
Contributor Author

hcyuser commented Aug 10, 2023

If we didn't add a callback in req.logout(callback),
It would get Error: req#logout requires a callback function on the webpage when running node app.js and clicking Sign out on the webpage.

@jackycute
Copy link
Member

@Yukaii
Copy link
Member

Yukaii commented Dec 26, 2023

closed in favor of #1837

@Yukaii Yukaii closed this Dec 26, 2023
@stanley2058 stanley2058 mentioned this pull request Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants