This repository has been archived by the owner on Jul 6, 2019. It is now read-only.
Doc comments for hal and lib. #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc #82 |
| @@ -20,8 +20,7 @@ Some pins that could be configured here may be missing from actual MCU depending | |||
| on the package. | |||
| */ | |||
|
|
|||
| use core::intrinsics::abort; | |||
| use core::option::{Option, Some, None}; | |||
| use core::option::{Option}; | |||
|
Thanks for the cleanup work. I've added a few comments on that. |
|
r? |
6 tasks
| #[inline(always)] | ||
| pub fn init_stack() { | ||
| set_stack_limit((&_eglobals as *const u32) as u32); | ||
| } | ||
|
|
||
| /// Helper function to copy over .data from rom to ram and zero out .bss | ||
| /// Helper function to initialize memory. | ||
| /// Copies .data sections in from RAM and initialized .bss sections to zero. |
There was a problem hiding this comment.
I'd quote those with backticks, i.e. .data and .bss...
|
Not sure if you are still reviewing. But I made the changes to the bss/data stuff. |
hacknbot
added a commit
that referenced
this pull request
Jul 30, 2014
Doc comments for hal and lib. Reviewed-by: farcaller
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just leaves
drivers(andplatformtree) to go.