Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes references to cast module. #40

Merged
merged 1 commit into from May 20, 2014

Conversation

Projects
None yet
2 participants
@bharrisau
Copy link
Contributor

commented May 20, 2014

Also fixes change from extern unsafe to unsafe extern. fixes #39

Removes references to cast module.
Also fixes change from `extern unsafe` to `unsafe extern`. fixes #39

// TODO(bharrisau) I don't know enough about markers - is it better

This comment has been minimized.

Copy link
@bharrisau

bharrisau May 20, 2014

Author Contributor

@farcaller Any suggestions here?

@farcaller

This comment has been minimized.

Copy link
Member

commented May 20, 2014

So, what's happening with libcore, cast is removed now?

PS: sorry, I'm kind of on a vacation, expect delays with my responses, blame bad wifi.

@bharrisau

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2014

Transmute was moved into mem, the rest were dropped. The Cell<T> type uses Unsafe<T> internally, I wasn't sure if we wanted to also. It can wait till your holiday is over, I'll merge this to fix the build errors with rust master.

bharrisau added a commit that referenced this pull request May 20, 2014

Merge pull request #40 from bharrisau/remove_cast
Removes references to cast module.

@bharrisau bharrisau merged commit 3098bdf into hackndev:master May 20, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@bharrisau bharrisau deleted the bharrisau:remove_cast branch May 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.