Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<abstr> type could be perhaps described more accurately #9

Closed
villesau opened this issue Dec 19, 2018 · 4 comments
Closed

<abstr> type could be perhaps described more accurately #9

villesau opened this issue Dec 19, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@villesau
Copy link

villesau commented Dec 19, 2018

Looks like <abstr> is used when type information is hard to retrieve. looks like path has some more info about the <abstr> type. e.g in this case cx has type Context when attaching debugger on line https://github.com/hackwaly/ocamlearlybird/blob/master/ocaml_debug_adapter/inspect.ml#L367

There might be even more information that could be shown in debugger. I think that cx in this case has some data in it too, but only <abstr> is shown. this is how cx looks like: https://github.com/facebook/flow/blob/master/src/typing/context.ml

screenshot 2018-12-20 at 0 44 55

@hackwaly hackwaly added the enhancement New feature or request label Dec 20, 2018
@villesau
Copy link
Author

villesau commented Dec 20, 2018

I think that in this case the <abstr> cx type is actually record. @hackwaly do you have a plan how to implement support for that?

@hackwaly
Copy link
Owner

I know this issue. And I need what to reproduce it. Or you can give me simpler code (eg, only one main.ml) other than flow codebase to debug?

@villesau
Copy link
Author

villesau commented Dec 21, 2018

@hackwaly unfortunately I don't have simpler code base for you :/ But I think that it actually happens with ocamlearlybird as well but i'm not 100% sure.

Here are debugging instructions for Flow: facebook/flow#4181 (comment) and here setup instructions: https://github.com/facebook/flow#building-flow

If you put breakpoint in flow_js.ml to any place that uses cx variable, you see the problem.

@hackwaly
Copy link
Owner

superseded by #52

sim642 added a commit to sim642/opam-repository that referenced this issue Jan 5, 2024
CHANGES:

### Added

* Add opaque value inspection using runtime representation (hackwaly/ocamlearlybird#9, hackwaly/ocamlearlybird#52, hackwaly/ocamlearlybird#53).
nberth pushed a commit to nberth/opam-repository that referenced this issue Jun 18, 2024
CHANGES:

### Added

* Add opaque value inspection using runtime representation (hackwaly/ocamlearlybird#9, hackwaly/ocamlearlybird#52, hackwaly/ocamlearlybird#53).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants