Add Visual Studio Code workspace configuration #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgefst
commented
Nov 2, 2021
primer-app.code-workspace
Outdated
| "arrterian.nix-env-selector", | ||
| "b4dm4n.nixpkgs-fmt", | ||
| "bbenoist.nix", | ||
| "dbaeumer.vscode-eslint", |
There was a problem hiding this comment.
Somehow I get a lot of eslint warnings which don't appear on CI. I'm still investigating that.
georgefst
commented
Nov 2, 2021
primer-app.code-workspace
Outdated
| "files.insertFinalNewline": true, | ||
| "files.trimFinalNewlines": true, | ||
| "files.trimTrailingWhitespace": true, | ||
| "nixEnvSelector.nixFile": "${workspaceRoot}/shell.nix", |
There was a problem hiding this comment.
This isn't ideal, but there's no flake support yet: arrterian/nix-env-selector#53.
And we're rarely needing to reload the editor in practice, so the fact that it takes a few seconds longer isn't a huge issue.
|
I'm fine with this, so just go ahead and commit it when you're finished with the config. |
georgefst
commented
Nov 2, 2021
We were sticking to VScode's built-in formatter, since I thought `primer-app.code-workspace` was the only "jsonc" file in the project. But it turns out that the `tsconfig.json` files also allow comments, and we use Prettier on those.
As was configured in the previous commit.
Prettier handles this for us on all source files anyway, and for other files we needn't care (there is currently trailing whitespace in the README, at least).
|
bors merge |
|
Build succeeded: |
ghost
merged commit
This was referenced Nov 3, 2021
ghost
pushed a commit
that referenced
this pull request
Nov 8, 2021
ghost
pushed a commit
that referenced
this pull request
Nov 8, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've argued against editor-specific configuration before, but this would be a useful way for me to be able to share settings with @annedino4...