Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Visual Studio Code workspace configuration #117

Merged
5 commits merged into from
Nov 3, 2021
Merged

Commits on Nov 2, 2021

  1. Configuration menu
    Copy the full SHA
    ee448fb View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2021

  1. Configure VScode to use Prettier for JSON files which allow comments

    We were sticking to VScode's built-in formatter, since I thought `primer-app.code-workspace` was the only "jsonc" file in the project. But it turns out that the `tsconfig.json` files also allow comments, and we use Prettier on those.
    georgefst committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    642c694 View commit details
    Browse the repository at this point in the history
  2. Format VScode workspace config with Prettier

    As was configured in the previous commit.
    georgefst committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    cba5c04 View commit details
    Browse the repository at this point in the history
  3. Remove VScode settings for normalising whitespace

    Prettier handles this for us on all source files anyway, and for other files we needn't care (there is currently trailing whitespace in the README, at least).
    georgefst committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    a95f4a9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1244bd1 View commit details
    Browse the repository at this point in the history