fix(dagre): Tell vite not to ignore try/catch for CommonJS modules. #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhess
force-pushed
the
dhess/fix-chromatic
branch
5 times, most recently
from
e4eda7f
to
830c028
Compare
This commit fixes the Chromatic issue we've been having with dagre. It also preemptively applies the same workaround to the `primer-app` package, as it's likely we'd have had the same issue for production builds of the app. For details, see: vitejs/vite#5759
Now that we can deploy successfully to Chromatic again, building the `primer-components` Storybook ourselves rather than relying on Chromatic to build it saves us a separate CI workflow.
dhess
force-pushed
the
dhess/fix-chromatic
branch
from
830c028
to
be45ad9
Compare
dhess
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the Chromatic issue we've been having with dagre. It
also preemptively applies the same workaround to the
primer-apppackage, as it's likely we'd have had the same issue for production
builds of the app.
For details, see:
vitejs/vite#5759