New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UnmanagedSystem support in ECS Integration #467
Add UnmanagedSystem support in ECS Integration #467
Conversation
…nyin/VContainer into feature/ecs-unmanaged-system # Conflicts: # VContainer/Assets/VContainer/Runtime/Unity/ContainerBuilderUnityExtensions.cs # VContainer/Assets/VContainer/Runtime/Unity/InstanceProviders/UnmanagedSystemInstanceProvider.cs # VContainer/Assets/VContainer/Runtime/Unity/UnmanagedSystemReference.cs
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -1,4 +1,5 @@ | |||
using System; | |||
using Unity.Entities; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we need the #if
directive ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my mistake. i had remove this line.
@stenyin Very interesting and appreciated as I have not been able to catch up on the new features of the ecs. thanks for the PR. I would like to merge, but it would be very helpful if you could confirm two points.
I would be happy to have it confirmed. Thanks. |
|
…reprocessor symbol.
Thanks for the checking.
Sounds like a good idea. |
Thank you for your response. I have confirmed that versions lower than ecs 1.0 cannot be used normally in 2022.2, so I believe using the Unity version as a check is a feasible solution (unless consideration is needed for those using 2022.2.0a1-2022.2.0b7 versions). |
Ok, Could you fix this PR to checking the Unity version? |
Are there any additional changes needed before this can be merged in @hadashiA? |
Sorry I haven't replied in a while, but for work and personal reasons. I'll test it again. |
26e588e
to
8f434a1
Compare
Additionally, references to Unity.Collections have been added in `VContainer.Tests.asmdef` and `VContainer.asmdef`, to support ECS update. Remove "VCONTAINER_ECS_INTEGRATION_1_0"
Sorry for late reply. Looks good for me. Thanks! |
This pull request adds support for UnmanagedSystem in the ECS Integration feature of VContainer. The changes include new extension methods for ContainerBuilder that allow for easy registration of UnmanagedSystems from a specific World, as well as new classes for handling the creation and disposal of UnmanagedSystem references.
This update also includes the ability to add a system to a specific system group using IntoGroup method.
This should be a useful addition for those using UnmanagedSystems in their projects, and will make it easier to manage the lifetimes of these systems in conjunction with VContainer.
I've tested the changes and it's working well. Please let me know if there's anything else needed.
Note: this feature requires the VCONTAINER_ECS_INTEGRATION_1_0 preprocessor symbol to be defined in order to use it.