Models start 1-index #129
Merged
Models start 1-index #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomcteixeira
added
the
enhancement
rvhonorato
approved these changes
Nov 22, 2021
Codecov Report
@@ Coverage Diff @@
## main #129 +/- ##
=======================================
Coverage 43.32% 43.32%
=======================================
Files 38 38
Lines 1879 1879
=======================================
Hits 814 814
Misses 1065 1065
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before models were starting 0-index line in python. Now they start 1-index.
@amjjbonvin do you think it is useful to have also models named
01,02, ... if there are up to 99 models and001,002, etc if there are up 999 models, etc, to facilitatelscommand? Or is it going to break any CNS part?