Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add queue parameter to libhpc #205

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Add queue parameter to libhpc #205

merged 1 commit into from
Dec 20, 2021

Conversation

rvhonorato
Copy link
Member

This closes #204

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2021

Codecov Report

Merging #205 (3433acd) into main (04e2e30) will decrease coverage by 0.30%.
The diff coverage is 4.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
- Coverage   39.90%   39.59%   -0.31%     
==========================================
  Files          42       42              
  Lines        2411     2432      +21     
==========================================
+ Hits          962      963       +1     
- Misses       1449     1469      +20     
Impacted Files Coverage Δ
src/haddock/modules/__init__.py 35.00% <ø> (ø)
src/haddock/libs/libhpc.py 18.70% <4.00%> (-2.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04e2e30...3433acd. Read the comment docs.

Copy link
Member

@joaomcteixeira joaomcteixeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy to see that with this setup it is clear where to add new variables and how to pass them down the line.

@rvhonorato rvhonorato merged commit ab4a72f into main Dec 20, 2021
@rvhonorato rvhonorato deleted the 204 branch December 20, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add queue parameter to HPC mode
4 participants