Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement lt, gt and eq operators to PDBFile #266

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Implement lt, gt and eq operators to PDBFile #266

merged 2 commits into from
Jan 7, 2022

Conversation

rvhonorato
Copy link
Member

This PR closes #251 by implementing the lt, gt and eq to PDBFile.

@rvhonorato rvhonorato self-assigned this Jan 7, 2022
@joaomcteixeira joaomcteixeira added m|caprieval Improvements in caprieval module enhancement Enhancing an existing feature of adding a new one labels Jan 7, 2022
@joaomcteixeira joaomcteixeira added this to the v3.0.0 stable release milestone Jan 7, 2022
@rvhonorato rvhonorato added the m|clustfcc clustfcc module label Jan 7, 2022
Copy link
Member

@joaomcteixeira joaomcteixeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

some comments for fun, nothing more 🐱

src/haddock/libs/libontology.py Show resolved Hide resolved
@rvhonorato rvhonorato merged commit 3944739 into main Jan 7, 2022
@rvhonorato rvhonorato deleted the 251 branch January 7, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancing an existing feature of adding a new one m|caprieval Improvements in caprieval module m|clustfcc clustfcc module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

caprieval fails if models from previous step do not have scores
2 participants