Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

tile in topoaa.defaults.mol1 should be title #361

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

sverhoeven
Copy link
Contributor

@sverhoeven sverhoeven commented Mar 9, 2022

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and you comply with the following criteria:

  • You have stick to Python. Talk with us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there's a (state) purpose
  • code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any install dependencies unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 馃敟
  • Your PR is about writing tests for already existing code :godmode:

Fix small typo that tripped up my defaults parser.

@joaomcteixeira
Copy link
Member

My question is.. how did that pass the tests? Let me check

@joaomcteixeira
Copy link
Member

Got it. this was something new we added. Before mol1 did not have those keys. Adding tests for that.

@joaomcteixeira joaomcteixeira self-requested a review March 9, 2022 15:55
@joaomcteixeira joaomcteixeira added this to Needs triage in Bugs via automation Mar 9, 2022
@joaomcteixeira joaomcteixeira added bug Something isn't working yaml default parameters Anything related to the YAML configuration files for default parameters labels Mar 9, 2022
@joaomcteixeira joaomcteixeira moved this from Needs triage to Low priority in Bugs Mar 9, 2022
@joaomcteixeira joaomcteixeira merged commit 9eb131a into haddocking:main Mar 9, 2022
Bugs automation moved this from Low priority to Closed Mar 9, 2022
@sverhoeven
Copy link
Contributor Author

Thanks for the quick merge.

@sverhoeven sverhoeven deleted the patch-1 branch March 9, 2022 15:58
@joaomcteixeira joaomcteixeira mentioned this pull request Mar 9, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working yaml default parameters Anything related to the YAML configuration files for default parameters
Projects
Bugs
  
Closed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants